Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bridges list in genesis config (fixes #515) #520

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

Nutomic
Copy link
Contributor

@Nutomic Nutomic commented Mar 9, 2023

Summary of changes
Changes introduced in this pull request:

  • Adds bridges parameter to bridge-registry GenesisConfig which allows adding bridges at build time
  • Add a testing bridge in testnet_genesis() chainspec
  • Fix for crash in submitProposals.ts (@shekohex)
  • Use existing ResourceId struct instead of typedef
  • Use cargo run in scripts/run-standalone.sh instead of executing binary, so that separate build step is not necessary
  • Extract some constants from chainspec code

Reference issue to close (if applicable)

Closes #515

@Nutomic Nutomic requested a review from shekohex March 9, 2023 12:00
}
}],
..Default::default()
},
Copy link
Contributor Author

@Nutomic Nutomic Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are the bridge parameters being passed in. This works and shows up as expected in polkadot web ui.

However the test case in tangle-network/relayer#355 is failing now with Metadata(IncompatibleStorageMetadata("BridgeRegistry", "Bridges")), I think its necessary to update the dependency in webb-rs crate to fix it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, this needs an Update to webb-rs, can you generate the new metadata locally and use the local version of webb-rs to test that?

Copy link
Contributor Author

@Nutomic Nutomic Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did that according to instructions, files src/substrate/dkg_runtime.rs and src/substrate/protocol_substrate_runtime.rs got updated. I changed the relayer webb dependency to use the local repo path, however its still giving the same error. Not sure what Im missing.

Edit: managed to fix this

@shekohex
Copy link
Contributor

shekohex commented Mar 9, 2023

Needs to fix the CI, and this good to be merged!

@Nutomic Nutomic force-pushed the felix/initialize-bridge-metadata branch from 28b902f to 895391b Compare March 9, 2023 13:52
@Nutomic Nutomic force-pushed the felix/initialize-bridge-metadata branch from 895391b to 978261e Compare March 9, 2023 14:43
@shekohex shekohex merged commit e37ef09 into master Mar 9, 2023
@shekohex shekohex deleted the felix/initialize-bridge-metadata branch March 9, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TASK] Add BridgeMetadata list in the Genesis config
2 participants