feat(gadget-sdk)!: integrate blueprint-serde
#469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge conflicts here @Serial-ATA and then g2g |
Serial-ATA
force-pushed
the
serial/integrate-blueprint-serde
branch
from
eb5567e
to
00da9a6
Compare
shekohex
approved these changes
Nov 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of the manual conversions does with the
ValueIntoFieldTypetrait andfield_type_to_param_tokenutils, letting all conversions be unified underblueprint-serde.This doesn't support custom struct args yet, that's a future (more complicated) issue.