Implement display trait for ResourceId #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
force-pushed
the
felix/display-resource-id
branch
from
7b1465d
to
68b95ae
Compare
2 tasks
|
Well this overall good for debugging, however, it is not good for filtering information, by nature the resource Ids are designed to be machine readable, easy to decode and encode, but not designed to be readable by us, humans; Hence tangle-network/relayer#387 Task was trying to open the idea of how we could make the metrices system dynamic and at the same time human readable, so that we can represent it to the Relayer operator. |
|
Okay I changed these to debug impls (replacing derived ones) and removed the tests. Will implement metrics like you suggested in the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For tangle-network/relayer#387. You can see the tests for examples how the resources are rendered. Im open for suggestions how to improve that.