Add tags support #12
Open
Add tags support #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this looks just amazing! |
|
I tried merging this locally, currently getting this error:
|
|
Thanks for letting me know @ribice ! This issue happens when there is only one tag in a post. I just pushed a fix to this PR. |
|
Hi, Included these changes in a fork of mine (link). Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Credits to @a-urth PR #8
However, I feel the footprint of his tag implementation doesn't fit hemingway's minimalist style. So I did some modification and try to keep it as close to current feeling as possible.
A live demo can be found here: https://jiulongw.github.io/
Hope this would be useful to others who like this theme but need tag support!