Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update minimum illuminate/support version to only ^7 #34

Closed
nathanczachur opened this issue Aug 11, 2020 · 1 comment
Closed

Comments

@nathanczachur
Copy link

Thanks for all the work on this package, its a real time saver!

I have found an issue with the composer.json, it says it works with lower versions of the illuminate/support package, however it doesn't.

If you look here:
https://github.com/tanmuhittin/laravel-google-translate/blob/master/src/TranslationFileTranslators/PhpArrayFileTranslator.php#L59

Str::of()->dirname()

This functionality was added to illuminate/support/Str in version 7.

So, we need to update the composer.json to say we only support version 7. Currently, it shows support from version 5.5 to 7:

"illuminate/support": "^5.5|^6|^7",

@nathanczachur
Copy link
Author

I have gotten round this by patching that line in my local package, just switching:

Str::of($file)->dirname()

For

dirname($file)

If you wanted to still include support for older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants