Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol/get-parsed-reply fn #192

Closed
wants to merge 1 commit into from

Conversation

firesofmay
Copy link
Collaborator

This bug was introduced in commit -
a2bef0c

By mistake the arguments to get function were swapped, hence 1 test in
taoensso.carmine.tests.main ns have been failing since then.

This fixes it.

Test output:

$ lein clean; lein expectations taoensso.carmine.tests.main

Benching (this can take some time)
----------------------------------

Lap 1/1...
{:wcar 43, :ping 447, :set 394, :get 399, :roundtrip 496, :ping-pipelined 2012}

Done! (Time for cake?)

Ran 118 tests containing 118 assertions in 8643 msecs
�[32m0 failures, 0 errors�[0m.

This bug was introduced in commit -
a2bef0c

By mistake the arguments to get function were swapped, hence 1 test in
taoensso.carmine.tests.main ns have been failing since then.

This fixes it.
@ptaoussanis
Copy link
Member

Good catch, thank you Mayank! Will merge this in a batch with the test PR/s later. Cheers!

@ptaoussanis ptaoussanis self-assigned this Mar 19, 2017
@ptaoussanis
Copy link
Member

Merged, thanks again!

ptaoussanis pushed a commit that referenced this pull request Mar 24, 2017
This bug was introduced in commit -
a2bef0c

By mistake the arguments to get function were swapped, hence 1 test in
taoensso.carmine.tests.main ns have been failing since then.

This fixes it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants