[#244] MQ: Add initial-backoff option to enqueue #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@st3fan Hi Stefan, definitely open for a PR- and this is looking good, thanks!
Allowed + wanted 👍 |
ptaoussanis
reviewed
Nov 23, 2020
ptaoussanis
reviewed
Nov 23, 2020
|
Thank you for tips - I'll work on some improvements and better tests. I also left a question at https://github.com/ptaoussanis/carmine/pull/245/files#diff-9f2681c4ea1ec7b7c79bb31ad60f7b4847786cd2b4f3df935e8eb8c58869d364R176 but now I am actually wondering if the behaviour under that comment is correct .. if there are two messages available, should |
st3fan
force-pushed
the
st3fan/initial-backoff
branch
2 times, most recently
from
07ee929
to
9af62e4
Compare
ptaoussanis
requested changes
Nov 24, 2020
st3fan
force-pushed
the
st3fan/initial-backoff
branch
from
6ef7866
to
76dfe61
Compare
ptaoussanis
pushed a commit
that referenced
this pull request
Nov 24, 2020
ptaoussanis
added a commit
that referenced
this pull request
Nov 24, 2020
|
https://github.com/ptaoussanis/carmine/releases/tag/v3.1.0 is now on Clojars 👍 Cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #244 - This patch adds an
:initial-backoff-msoption toenqueue. I implemented this by allowing an initial value to be set in theqk-backoffshash on message creation. This seems to do the trick.Also included a new test to validate the
:initial-backoff-msbehaviour. I think it would be interesting to do a bit of a stress test with this feature - are longer running tests allowed/wanted?