-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add host-chsk-url-fn #136
Add host-chsk-url-fn #136
Conversation
To make things simpler for people creating cross domain channel sockets
If you'd prefer fewer functions in the main Sente ns, the other option I thought of was making |
Hi Daniel, thanks for this. As I mentioned last time this came up (in #50), I'm not convinced it makes sense to add any specialised code for the use case you're describing. An appropriate chsk-url-fn can usually be expressed more flexibly and transparently as a small inline fn, no? What problem are you actually trying to solve here? Is it that you feel users won't understand how to write an appropriate chsk-url-fn? Could that not better be solved by adding a short cross-domain example to the Cheers :-) |
I thought that users may not understand how to write the chsk-url-fn correctly. A docstring would be fine too if you'd prefer that. |
Okay, going to simplify this. Will keep For the simpler common-case that you're describing, have added a |
Sure, if you prefer that, I'm happy with any of the options. |
Great, closing this then. Change is up on the dev branch and |
It would be helpful for people using cross domain channel sockets to have a simplified
chsk-url-fn
for making connections to different hosts. This PR adds the function, and documentation on how to use it.