Server adapters for express and dogfort on node.js #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! |
ptaoussanis
added a commit
that referenced
this pull request
Jan 31, 2016
Server adapters for express and dogfort on node.js
ptaoussanis
pushed a commit
that referenced
this pull request
Jan 31, 2016
ptaoussanis
added a commit
that referenced
this pull request
Jan 31, 2016
BREAKING:
- Renamed: `taoensso.sente.server-adapters.express/make-express-adapter`
-> `''/make-express-channel-socket-server!`
|
@theasp Hi Andrew, Please note that I made a breaking change by renaming Also, have added a few TODOs to https://github.com/ptaoussanis/sente/blob/dev/src/taoensso/sente/server_adapters/express.cljs that maybe I could ask you to take a look at when you have time? Will try get an updated 1.8.0 alpha cut soon after you given me the go-ahead. Cheers :-) |
ptaoussanis
added a commit
that referenced
this pull request
Feb 1, 2016
BREAKING:
- Renamed: `taoensso.sente.server-adapters.express/make-express-adapter`
-> `''/make-express-channel-socket-server!`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Here are the server adapters for dogfort (@whamtet) and express. I refactored the generic-node adapter since the previous PR.
You can try them out using my example repository:
https://github.com/theasp/sente-nodejs-example