-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert host overriding functionality #353
Conversation
@ptaoussanis This is important. Sente is currently unusable e.g. in React-native apps, as window location doesn't mean anything. But I think this fix should also support case where both |
@Deraen You can provide the port as part of the |
There is no Doesn't matter if |
@Deraen Sure there is no |
I can confirm this totally breaks Sente for React Native. Also currently React Native users have to set a system property to build their projects, which is undesirable with tools like shadow-cljs which re-use the same JVM process for multiple builds simultaneously. In this comment, I proposed a solution that doesn't require setting a system property. |
Addressing now via #366 - apologies for the delay on this. |
No worries at all @ptaoussanis, thanks for the awesome library! |
A previous PR broke the host overriding functionality. This commit fixes it.