Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #365

Closed
wants to merge 1 commit into from
Closed

Update README.md #365

wants to merge 1 commit into from

Conversation

mattford63
Copy link
Contributor

CSRF is now mandatory - it took me a whilst to find this out from the official example. This is quick pass at updating the readme to reflect this.

CSRF is now mandatory - it took me a whilst to find this out from the official example.   This is quick pass at updating the readme to reflect this.
mattford63 added a commit to mattford63/subber that referenced this pull request Feb 18, 2020
- provide a dynamic web socket (fall back to ajax) to communicate
  events over
- CRSF is now mandatory over sente but not reflected in the docs
  created upstream PR taoensso/sente#365
@armincerf
Copy link

Actually I don't think CSRF is mandatory, you can pass :csrf-token-fn nil in the make-channel-socket! options on the server side and it will skip the checks. I don't think that is documented though, I had to dig through the source to find it.

@ptaoussanis
Copy link
Member

Merging manually, thanks Matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants