Allows disabling ANSI colours w/ env var #172
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading
timbre
logs from files, stack traces include non-printable characters for the ANSI colour characters. This can become annoying after reading logs for a while.While it is possible to disable ANSI colours in stack traces using
(merge-config! {:output-fn (partial default-output-fn {:stacktrace-fonts {}})})
, including this in every app entry point is not ideal for people like me who believe colours in stack traces should be disabled by default. No colours in logs by default could be ideal for production systems, i.e..The changes here disable stack trace fonts when the environment variable
TIMBRE_NO_STACKTRACE_FONTS
is set. This doesn't break the previous behaviour of the library.