Replace usages of io.aviso/pretty with org.clj-commons/pretty #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A further note: org.clj-commons/pretty has built-in checks for whether its likely that output is directed to a console or not; in the latter case, ANSI formatting codes (font and color) are eliminated automatically; I'm not sure who logs to a file with ANSI formatting, but that's likely going to be an explicit opt-in (there's a system property that can be set to override the normal check). |
|
Thank you very much Howard! I'll definitely take a closer look at merging this when I'm next on batched Timbre work 👍 Cheers :-) |
ptaoussanis
force-pushed
the
master
branch
2 times, most recently
from
51a3b72
to
01513d4
Compare
ptaoussanis
added a commit
that referenced
this pull request
Feb 23, 2024
Pretty v2 introduced an incompatible change to its font format.
Few (if any?) Timbre users actually customize these fonts beyond
possibly disabling them, so this shouldn't affect most folks.
But to be on the safe side, this commit introduces handling for
possible v1 style fonts.
There's 2 cases:
1. [Compile-time] Invalid default fonts (set via environment variable / JVM property).
In this case Timbre will throw, preventing compilation.
2. [Runtime] Invalid fonts in output opts.
In this case Timbre will log an error and ignore the invalid fonts.
|
Will be addressed in upcoming release, closing 👍 |
ptaoussanis
added a commit
that referenced
this pull request
Feb 26, 2024
Pretty v2 introduced an incompatible change to its font format.
Few (if any?) Timbre users actually customize these fonts beyond
possibly disabling them, so this shouldn't affect most folks.
But to be on the safe side, this commit introduces handling for
possible v1 style fonts.
There's 2 cases:
1. [Compile-time] Invalid default fonts (set via environment variable / JVM property).
In this case Timbre will throw, preventing compilation.
2. [Runtime] Invalid fonts in output opts.
In this case Timbre will log an error and ignore the invalid fonts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue is that anyone who is using customized fonts (as per the documentation on the wiki) will see failures, because the values have changed from strings to keywords.
This may warrant a major version upgrade in Timbre, or at least, a strongly worded note in the change log.