fix: #274

taoqf · May 14, 2024 · fef574d · fef574d
1 parent 35b9f1f
commit fef574d
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 1 deletion.
diff --git a/src/nodes/html.ts b/src/nodes/html.ts
@@ -453,6 +453,14 @@ export default class HTMLElement extends Node {
 			this.childNodes[o++] = node;
 		});
 		this.childNodes.length = o;
+
+		// remove whitespace between attributes
+		const attrs = Object.keys( this.rawAttributes).map((key) => {
+			const val = this.rawAttributes[key];
+			return `${key}=${ JSON.stringify(val)}`;
+		}).join(' ');
+		this.rawAttrs = attrs;
+		delete this._rawAttrs;
 		return this;
 	}
 

diff --git a/test/tests/issues/274.js b/test/tests/issues/274.js
@@ -0,0 +1,17 @@
+const { parse } = require('@test/test-target');
+
+describe('issue 274', function () {
+	it('removeWhitespace + outerHTML dont remove meaningless white-spaces inside start and end tags', function () {
+		const html = `<!DOCTYPE html
+><html                     lang="en"
+><meta charset="UTF-8"
+><title>test</title
+
+><p>test</p
+
+></html>`;
+		const root = parse(html);
+		const el = root.querySelector('html').removeWhitespace();
+		el.outerHTML.should.eql('<html lang="en"><meta charset="UTF-8"><title>test</title><p>test</p></html>');
+	});
+});
diff --git a/tsconfig.json b/tsconfig.json
@@ -29,7 +29,8 @@
 		"inlineSources": false,
 		"isolatedModules": false,
 		"lib": [
-			"esnext"
+			"esnext",
+			"dom"
 		],
 		"listFiles": false,
 		"listEmittedFiles": false,