Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source location to nodes #126

Closed
wants to merge 4 commits into from
Closed

Add source location to nodes #126

wants to merge 4 commits into from

Conversation

milahu
Copy link

@milahu milahu commented Jun 4, 2021 •
edited
Loading

continue #107

use case: detect indent of node, so i can insert new nodes and preserve the indent level

status: tests are failing

sample code: wrap text node in a language-switch container

const nodeStart = node._source.start;
const lineStart = html.lastIndexOf('\n', nodeStart) + 1;
const indent = html.slice(lineStart, nodeStart).match(/^\s*/)[0];

node.classList.add('langs');
node.innerHTML = node.innerHTML.includes('\n')
  ? ([
      '',
      `  <div lang="en">`,
      `    ${node.innerHTML}`,
      `  </div>`,
      '',
    ].join('\n').replace(/\n/g, `\n${indent}`))
  : ([
      '',
      `  <div lang="en">${node.innerHTML}</div>`,
      '',
    ].join('\n').replace(/\n/g, `\n${indent}`))
;

small edits:

  • use npm run build instead of yarn build
  • add prepare script = duplicate of package.json: add prepare script #125
  • add classNames setter
  • move class string parsing to DOMTokenList._fromString
  • add per-target build scripts for faster development
  • not sure why i added this.id = keyAttrs.id
  • this.rawAttrs may need more work -> generate class and rawAttrs only on demand?

@taoqf
Copy link
Owner

taoqf commented Jun 5, 2021

Thanks, I did look into this and really could not understand.
What is purpose with this pr?
Would this slowdown the parsing and does this worth?

@milahu
Copy link
Author

milahu commented Jun 5, 2021

What is purpose with this pr?

assume we have this input

<html>
  <div class="old">
    hello
  </div>
</html>

i want to insert nodes into the <div class="old"> node
but the indent should be preserved:

<html>
  <div class="old">
    <div class="new">
      hello
    </div>
  </div>
</html>

with my patch, the parser will add the source location for every node
for example nodeDivOld._source.start == 20
to get the indent, i use the sample code in my first post

Would this slowdown the parsing and does this worth?

no benchmarks yet ...

this could be disabled by default, and enabled via parser options

this could be optimized with getter functions,
since every position has an offset of

const dataOffset = `<${frameflag}>`.length;

which could be subtracted in the getter function

@nonara
Copy link
Collaborator

nonara commented Jul 12, 2021

@milahu I believe #138 should solve your issue

@nonara nonara mentioned this pull request Jul 12, 2021
Merged
@milahu milahu closed this Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milahu @taoqf @nonara