Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onFinish not invoked for explicit stack #425

Open
badeball opened this issue Feb 5, 2018 · 1 comment
Open

onFinish not invoked for explicit stack #425

badeball opened this issue Feb 5, 2018 · 1 comment

Comments

@badeball
Copy link

badeball commented Feb 5, 2018

Hi,

The following test seems to fail in (at least) 4.8.0, is it supposed to? Is it nearly identical to this test, with the only difference being that I create a new test harness.

var tap = require("tap");
var tape = require("tape").createHarness()

tap.test("on finish", {timeout: 1000}, function (tt) {
    tt.plan(1);
    tape.onFinish(function() {
        tt.pass('tape ended');
    });
    tape('dummy test', function(t) {
        t.end();
    });
});
@badeball badeball changed the title onFailure not invoked for explicit stack onFinish not invoked for explicit stack Feb 18, 2018
ljharb added a commit that referenced this issue Jul 26, 2021
@ljharb
Copy link
Collaborator

ljharb commented Jul 26, 2021

I've added a branch with a failing test: https://github.com/substack/tape/compare/harness_onfinish for anyone who wants to try to pick this up.

ljharb added a commit that referenced this issue Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants