Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme.markdown #359

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Update readme.markdown #359

merged 1 commit into from
Jan 9, 2019

Conversation

perguth
Copy link
Contributor

@perguth perguth commented Apr 16, 2017

Mention flip-tape in the section "other". 🦊

@ljharb
Copy link
Collaborator

ljharb commented Apr 16, 2017

So is this the (deprecated in every other language and testing framework) "should" approach, where it polyfills matchers onto every value?

Does it work with Object.create(null) or with objects from other realms? What if I'm doing for..in over an object, won't the presence of the matchers suddenly break my code?

@perguth
Copy link
Contributor Author

perguth commented Apr 17, 2017

It only attaches tapes methods to the String prototype (see lines marked with // eslint-disable-line https://github.com/pguth/flip-tape/blob/master/index.js).

So in the case of a for...in loop over a String object your code would probably break. However I don't think for...in-ing over a String is a likely case. Nonetheless I should point that out in the readme.

@ljharb
Copy link
Collaborator

ljharb commented Apr 18, 2017

aha, i misunderstood. so you're just doing description.matcher(…) instead of matcher(…, description).

That's definitely much less problematic, so I no longer have a concern about including it in the readme. (I'm still confused why you wouldn't want matcher(description, …) to avoid any issues with screwing with String.prototype)

@ljharb ljharb merged commit 1693c34 into tape-testing:master Jan 9, 2019
ljharb added a commit that referenced this pull request Feb 9, 2019
[New] Implements TAP TODO directive (#254)
[New] add alias 'notDeepEquals' to 'notDeepEqual' function (#411)

[Fix] fix premature end of tests (and running sibling tests) when test includes subtests (#403, #222)
[Fix] only use one test runner for results, even if multiple streams are created (#404, #361, #105)
[Fix] windows: Show failure location even if driver letter is lowercase (#329)

[Docs] link to mixed tape (#445)
[Docs] Add electron-tap (#240)
[Docs] Add tape-promise into 'other' (#210)
[Docs] Mention [`flip-tape`](https://github.com/pguth/flip-tape/blob/master/README.md) in the section "other". (#359)
[Docs] Add an alternative ES6 tape runner (#328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants