Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade the dependencies to their latest version #505

Closed

Conversation

osdevisnot
Copy link

This pr upgrades tap and tap-parser to their latest version. I also tool the opportunity to upgrade concat-stream.

Looking forward to any feedback.

Few notable upstream changes:

  • tap-parser changed the signature - requiring us to create a class with new keyword
  • tap-parser added a parser.fullname field -
    tapjs/tap-parser@287e137 - my approach in this PR is to explicitly delete the parser.fullname property, but I can change the expectations too if that's more preferred.

@osdevisnot
Copy link
Author

Looking at the test failures, we might need to update the supported node version based on dependencies.

Notably, tap started depending on async/await, const and other modern javascript features, which would require us to bump supported node version from ~1.0 to ~6.0 at least.

@ljharb
Copy link
Collaborator

ljharb commented Apr 26, 2020

We will likely never drop any version of node that's currently supported. There's a reason we haven't upgraded all of the dev deps :-)

.gitignore Outdated Show resolved Hide resolved
.travis.yml Outdated
@@ -1,4 +1,4 @@
version: ~> 1.0
version: ~> 6.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference in travis yml versions?

package.json Outdated Show resolved Hide resolved
@osdevisnot
Copy link
Author

We will likely never drop any version of node that's currently supported. There's a reason we haven't upgraded all of the dev deps :-)

The motivation behind this PR is to be able to use the parallel testing feature introduced in tap version 13.

If I may ask, is there a specific reason to support node version if it reaches EOL status on node.js

@ljharb
Copy link
Collaborator

ljharb commented Apr 26, 2020

EOL status is irrelevant. People use it, and supporting it makes their platform upgrades easier.

Also, tape is used in browsers, and there are still people using IE 8 and 9.

tape’s tests are more than fast enough; parallel testing isn’t that much of a carrot for me.

@osdevisnot
Copy link
Author

ok, makes sense. Feel free to close this PR unless we want to change the support policies.

@ljharb
Copy link
Collaborator

ljharb commented Apr 26, 2020

@osdevisnot i'm still interested in some of the changes here; if you can get concat-stream updated to v2, and improve the editorconfig check, that's still worth getting in.

@osdevisnot osdevisnot mentioned this pull request Apr 26, 2020
@osdevisnot
Copy link
Author

osdevisnot commented Apr 26, 2020

great, closing this in favor of #506.

@ljharb
Copy link
Collaborator

ljharb commented Apr 26, 2020

Looks like the concat-stream update isn't going to work in node < 4.

@ljharb
Copy link
Collaborator

ljharb commented Apr 26, 2020

As such, I'm going to close this and #506; since it turns out, every non-updated dev dep was because updating it would break things :-)

@ljharb ljharb closed this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants