-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade the dependencies to their latest version #505
Conversation
Looking at the test failures, we might need to update the supported node version based on dependencies. Notably, |
We will likely never drop any version of node that's currently supported. There's a reason we haven't upgraded all of the dev deps :-) |
.travis.yml
Outdated
@@ -1,4 +1,4 @@ | |||
version: ~> 1.0 | |||
version: ~> 6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the difference in travis yml versions?
The motivation behind this PR is to be able to use the parallel testing feature introduced in tap version 13. If I may ask, is there a specific reason to support node version if it reaches EOL status on |
EOL status is irrelevant. People use it, and supporting it makes their platform upgrades easier. Also, tape is used in browsers, and there are still people using IE 8 and 9. tape’s tests are more than fast enough; parallel testing isn’t that much of a carrot for me. |
ok, makes sense. Feel free to close this PR unless we want to change the support policies. |
@osdevisnot i'm still interested in some of the changes here; if you can get concat-stream updated to v2, and improve the editorconfig check, that's still worth getting in. |
great, closing this in favor of #506. |
e44bae1
to
89a0f11
Compare
Looks like the concat-stream update isn't going to work in node < 4. |
As such, I'm going to close this and #506; since it turns out, every non-updated dev dep was because updating it would break things :-) |
This pr upgrades
tap
andtap-parser
to their latest version. I also tool the opportunity to upgradeconcat-stream
.Looking forward to any feedback.
Few notable upstream changes:
tap-parser
changed the signature - requiring us to create a class withnew
keywordtap-parser
added a parser.fullname field -tapjs/tap-parser@287e137 - my approach in this PR is to explicitly delete the
parser.fullname
property, but I can change the expectations too if that's more preferred.