Added logic for working with Tarantool schema via Box #426

KaymeKaydex · 2024-12-27T17:17:22Z

Implemented the box.Schema() method that returns a Schema object for schema-related operations

What has been done? Why? What problem is being solved?

I didn't forget about (remove if it is not applicable):

Tests (see documentation for a testing package)
Changelog (see documentation for changelog format)
Documentation (see documentation for documentation style guide)

Related issues:

box/box_test.go

box/schema.go

box/tarantool_test.go

box/schema_user.go

oleg-jukovec

Please, add more unit-tests for a new requests/response. You could see how it is tested on the main package and inside the crud subpackage.

We also need examples (in example_test.go) with new features. This will help users to use the library.

Finally, we need to keep a backward compatibility until a next major release, so we need to add another Info() method with a context instead of changing the current one.

CHANGELOG.md

KaymeKaydex · 2025-01-21T15:16:30Z

Please, add more unit-tests for a new requests/response. You could see how it is tested on the main package and inside the crud subpackage.

We also need examples (in example_test.go) with new features. This will help users to use the library.

Finally, we need to keep a backward compatibility until a next major release, so we need to add another Info() method with a context instead of changing the current one.

i removed interface changes
added new examples for new methods
and added more tests to make coverage up, now all methods are covered

oleg-jukovec

Please, fix the commit message:

box: ddded logic for working with Tarantool schema

Implemented the `box.Schema()` method that returns a `Schema`
object for schema-related operations

CHANGELOG.md

box/example_test.go

box/schema_test.go

box/schema_user.go

box/tarantool_test.go

KaymeKaydex · 2025-01-28T20:24:30Z

Please, fix the commit message:

box: ddded logic for working with Tarantool schema

Implemented the `box.Schema()` method that returns a `Schema`
object for schema-related operations

done

Implemented the `box.Schema()` method that returns a `Schema` object for schema-related operations

oleg-jukovec · 2025-02-05T07:46:55Z

box/schema_test.go

+	t.Run("internal sugar sub-objects not panics", func(t *testing.T) {
+		require.NotNil(t, b)
+		require.NotNil(t, b.User())
+	})
+
+	t.Run("check that connections are equal", func(t *testing.T) {
+		var tCases []tarantool.Doer
+		for i := 0; i < 10; i++ {
+
+			doer := test_helpers.NewMockDoer(t)
+			tCases = append(tCases, &doer)
+		}
+
+		for _, tCase := range tCases {
+			sch := NewSchema(tCase)
+			require.Equal(t, tCase, sch.conn)
+			require.Equal(t, tCase, sch.User().conn)
+		}
+	})
+
+	t.Run("nil conn panics", func(t *testing.T) {


Please, split it into 3 separate tests.

oleg-jukovec · 2025-02-05T07:47:46Z

box/tarantool_test.go

+	t.Run("can connect with new credentials", func(t *testing.T) {
+		t.Parallel()
+		// Check that password is valid and we can connect to tarantool with such credentials
+		var newUserDialer = tarantool.NetDialer{
+			Address:  server,
+			User:     username,
+			Password: password,
+		}
+
+		// We can connect with our new credentials
+		newUserConn, err := tarantool.Connect(ctx, newUserDialer, tarantool.Opts{})
+		require.NoError(t, err)
+		require.NotNil(t, newUserConn)
+		require.NoError(t, newUserConn.Close())
+	})
+	t.Run("create user already exists error", func(t *testing.T) {


The same, please, split it into separate tests instead of the nesting.

oleg-jukovec · 2025-02-05T07:47:53Z

box/tarantool_test.go

+
+	b := box.New(conn)
+
+	t.Run("drop user after create", func(t *testing.T) {


oleg-jukovec · 2025-02-05T07:47:57Z

box/tarantool_test.go

+
+	b := box.New(conn)
+
+	t.Run("user not found", func(t *testing.T) {


oleg-jukovec · 2025-02-05T07:48:02Z

box/tarantool_test.go

+
+	b := box.New(conn)
+
+	t.Run("test user privileges is correct", func(t *testing.T) {


oleg-jukovec · 2025-02-05T07:48:06Z

box/tarantool_test.go

+	err = b.Schema().User().Create(ctx, username, box.UserCreateOptions{Password: password})
+	require.NoError(t, err)
+
+	t.Run("can`t grant without su permissions", func(t *testing.T) {


oleg-jukovec · 2025-02-05T07:48:11Z

box/tarantool_test.go

+	err = b.Schema().User().Create(ctx, username, box.UserCreateOptions{Password: password})
+	require.NoError(t, err)
+
+	t.Run("can`t revoke without su permissions", func(t *testing.T) {


oleg-jukovec · 2025-02-05T07:48:15Z

box/tarantool_test.go

+
+	b := box.New(conn)
+
+	t.Run("su with call", func(t *testing.T) {


KaymeKaydex force-pushed the box/schema branch 2 times, most recently from 2e271da to 9f736f4 Compare December 27, 2024 17:51

oleg-jukovec reviewed Dec 29, 2024

View reviewed changes

KaymeKaydex force-pushed the box/schema branch 10 times, most recently from 07de408 to 0a3720b Compare January 10, 2025 10:54

KaymeKaydex requested a review from oleg-jukovec January 10, 2025 10:57

KaymeKaydex force-pushed the box/schema branch from 0a3720b to 3155a23 Compare January 10, 2025 11:04

oleg-jukovec requested changes Jan 15, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

KaymeKaydex force-pushed the box/schema branch 11 times, most recently from 5c9bb77 to 1e3625c Compare January 21, 2025 15:15

KaymeKaydex force-pushed the box/schema branch from 1e3625c to 75e1930 Compare January 21, 2025 15:18

KaymeKaydex requested a review from oleg-jukovec January 21, 2025 15:20

KaymeKaydex force-pushed the box/schema branch 10 times, most recently from c729ca9 to 54b7b75 Compare January 23, 2025 12:30

oleg-jukovec reviewed Jan 23, 2025

View reviewed changes

KaymeKaydex force-pushed the box/schema branch 9 times, most recently from b82d157 to e8b3f1f Compare January 28, 2025 20:23

KaymeKaydex requested a review from oleg-jukovec January 28, 2025 20:24

KaymeKaydex force-pushed the box/schema branch from e8b3f1f to 40555ec Compare January 29, 2025 11:58

box: added logic for working with Tarantool schema

4954fc7

Implemented the `box.Schema()` method that returns a `Schema` object for schema-related operations

KaymeKaydex force-pushed the box/schema branch from 40555ec to 4954fc7 Compare January 30, 2025 09:19

oleg-jukovec approved these changes Feb 4, 2025

View reviewed changes

oleg-jukovec requested review from DerekBum and themilchenko February 4, 2025 16:04

oleg-jukovec requested changes Feb 5, 2025

View reviewed changes

KaymeKaydex closed this Feb 5, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added logic for working with Tarantool schema via Box #426

Added logic for working with Tarantool schema via Box #426

KaymeKaydex commented Dec 27, 2024 •

edited

Loading

oleg-jukovec left a comment •

edited

Loading

KaymeKaydex commented Jan 21, 2025

oleg-jukovec left a comment

KaymeKaydex commented Jan 28, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025

oleg-jukovec Feb 5, 2025


		b := box.New(conn)

		t.Run("drop user after create", func(t *testing.T) {


		b := box.New(conn)

		t.Run("user not found", func(t *testing.T) {


		b := box.New(conn)

		t.Run("test user privileges is correct", func(t *testing.T) {


		b := box.New(conn)

		t.Run("su with call", func(t *testing.T) {

Added logic for working with Tarantool schema via Box #426

Added logic for working with Tarantool schema via Box #426

Conversation

KaymeKaydex commented Dec 27, 2024 • edited Loading

oleg-jukovec left a comment • edited Loading

Choose a reason for hiding this comment

KaymeKaydex commented Jan 21, 2025

oleg-jukovec left a comment

Choose a reason for hiding this comment

KaymeKaydex commented Jan 28, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KaymeKaydex commented Dec 27, 2024 •

edited

Loading

oleg-jukovec left a comment •

edited

Loading