Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Commit

Permalink
Fix flaky fails with hang tests
Browse files Browse the repository at this point in the history
The problem is that frontend wait infinitely for a storage server, which
have not been initialized due to the error like the following.

```
Start failed: builtin/box/console.lua:560: failed to create server
localhost:57988: Address already in use
```

The problem is described in [1] (see comment itself, the issue is about
the another problem).

The gist of the fix is using unix sockets for admin console of
non-default servers (storages), it is why test-run update is needed. The
option 'use_unix_sockets' affects only console (admin) socket and does
nothing with binary (listen) port of a storage. It is critical in the
benchmarking test suite.

[1]: tarantool/test-run#115 (comment)
  • Loading branch information
Totktonada committed Sep 5, 2018
1 parent 5cd8a1f commit 77891e7
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 1 deletion.
2 changes: 1 addition & 1 deletion test-run
1 change: 1 addition & 0 deletions test/bench/suite.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ core = app
description = microbenchmarking
config = suite.cfg
is_parallel = False
use_unix_sockets = True
long_run =
forking-2-100-1.test.lua
forking-2-1-1.test.lua
Expand Down
1 change: 1 addition & 0 deletions test/common/suite.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ core = app
description = tests different setups simultaneously
config = suite.cfg
is_parallel = True
use_unix_sockets = True
1 change: 1 addition & 0 deletions test/extra/suite.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ core = app
description = tests on features which are not related to specific executor
is_parallel = True
config = suite.cfg
use_unix_sockets = True
1 change: 1 addition & 0 deletions test/space/suite.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ core = app
description = tests with space accessor
config = suite.cfg
is_parallel = False
use_unix_sockets = True

0 comments on commit 77891e7

Please sign in to comment.