Skip to content
This repository has been archived by the owner on Apr 14, 2022. It is now read-only.

Remove code duplication in multi-head connections #123

Closed
SudoBobo opened this issue Apr 16, 2018 · 2 comments
Closed

Remove code duplication in multi-head connections #123

SudoBobo opened this issue Apr 16, 2018 · 2 comments
Labels
archived code health Improve code readability, simplify maintenance and so on refactoring wontfix This will not be worked on

Comments

@SudoBobo
Copy link
Contributor

No description provided.

@Totktonada Totktonada removed their assignment Apr 16, 2018
@Totktonada Totktonada added refactoring code health Improve code readability, simplify maintenance and so on labels Apr 17, 2018
@SudoBobo SudoBobo self-assigned this May 4, 2018
@SudoBobo SudoBobo changed the title Remove code deduplication in multi-head connections Remove code duplication in multi-head connections May 4, 2018
@Totktonada
Copy link
Member

Seems to be done with PR #168 (1d2d206): resolve function code now reused. We still have separate function for 'boxing' multi-head connections and regular unions (and they cannot have 'List' postfix, yep?), but I don’t sure it is avoidable.

@SudoBobo Is it can be closed or we want to track something here?

SudoBobo added a commit that referenced this issue Aug 2, 2018
@SudoBobo
Add creation of avro-schema from query with
c9f2899 
multi-head connections,
Unions, Maps and directives

Also changed GraphQL Map type: now it has
subType = Map and name = values.type .. '_Map'
(Example: 'String_Map') This is to avoid name
clash.
Closes #200, closes #198, closes #197, closes
#123
SudoBobo added a commit that referenced this issue Aug 2, 2018
@SudoBobo
Add creation of avro-schema from query with
6e40bdc 
multi-head connections,
Unions, Maps and directives

Also changed GraphQL Map type: now it has
subType = Map and name = values.type .. '_Map'
(Example: 'String_Map') This is to avoid name
clash.
Closes #200, closes #198, closes #197, closes
#123
@SudoBobo SudoBobo mentioned this issue Aug 2, 2018
Merged
SudoBobo added a commit that referenced this issue Aug 2, 2018
@SudoBobo
Add creation of avro-schema from query with
588c9a2 
multi-head connections,
Unions, Maps and directives

Also changed GraphQL Map type: now it has
subType = Map and name = values.type .. '_Map'
(Example: 'String_Map') This is to avoid name
clash.
Closes #200, closes #198, closes #197, closes
#123
Totktonada added a commit that referenced this issue Sep 5, 2018
@Totktonada
WIP: Fix flaky fails with hang tests
2bbbb69 
The problem is that frontend wait infinitely for a storage server, which
have not been initialized due to the error like the following.

```
Start failed: builtin/box/console.lua:560: failed to create server
localhost:57988: Address already in use
```

The problem is described in [1] (see comment itself, the issue is about
the another problem).

The gist of the fix is using unix sockets for admin console of
non-default servers (storages). The option 'use_unix_sockets' affects
only console (admin) socket and does nothing with binary (listen) port
of a storage. It is critical in the benchmarking test suite.

TBD: update test-run from master after test-run's PR #123.

[1]: tarantool/test-run#115 (comment)
@Totktonada Totktonada mentioned this issue Sep 5, 2018
Merged
@Totktonada Totktonada added wontfix This will not be worked on archived labels Apr 13, 2022
@Totktonada
Copy link
Member

I'm going to archive the repository. I'll proceed as follows:

  • Mark all open pull requests with the archived label and close.
  • Mark all open issues with archived and wontfix labels and close.
  • Archive the repository.

Consider the following projects:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
archived code health Improve code readability, simplify maintenance and so on refactoring wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Totktonada @SudoBobo