Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support new CALL command with EVAL-style marshalling (1.7.1+) #101

Closed
rtsisyk opened this issue Aug 26, 2016 · 1 comment · Fixed by #167
Closed

Support new CALL command with EVAL-style marshalling (1.7.1+) #101

rtsisyk opened this issue Aug 26, 2016 · 1 comment · Fixed by #167
Assignees
@LeonidVas
Labels
feature A new functionality php7
Milestone
PHP 7.* + bugfixes

Comments

@rtsisyk
Copy link
Contributor

rtsisyk commented Aug 26, 2016

Tarantool 1.7.1 adds a new implementation of CALL command which supports EVAL-style marshalling, i.e. returned data is not converted to tuples anymore. Old CALL command (code = 6) is deprecated.
Please detect Tarantool version on connect and use code=10 for CALL if remote version >= 1.7.1.

tarantool/tarantool#1296
@rtsisyk rtsisyk added the feature A new functionality label Aug 26, 2016
@bigbes bigbes added the php7 label Sep 6, 2016
@bigbes bigbes self-assigned this Sep 6, 2016
@mejedi
Copy link

mejedi commented Sep 26, 2016 •
edited by bigbes
Loading

After internal discussions we decided that selecting old or new CALL automatically based on the server version is a bad idea after all. Client code will notice the difference in semantics.

Instead we suggest the following: make call behave in 1.7 semantics by default. Add connection option to configure calls semantics. If user wants 1.6 CALL-s, he should say so explicitly.

@Totktonada Totktonada added this to the PHP 7.* + bugfixes milestone Mar 23, 2020
@LeonidVas LeonidVas self-assigned this Jul 8, 2020
LeonidVas added a commit that referenced this issue Jul 16, 2020
@LeonidVas
add support of a new binary protocol command for "call"
ec19618 
Added support for a new binary protocol command for "call" (used
since 1.7.2).
The old version of "call" has been moved to "call_16".

Closes #101
@LeonidVas LeonidVas linked a pull request Jul 16, 2020 that will close this issue
Support call 17 #167
Merged
LeonidVas added a commit that referenced this issue Jul 16, 2020
@LeonidVas
add support of a new binary protocol command for "call"
0f9b6d2 
Added support for a new binary protocol command for "call" (used
since tarantool 1.7.2). Unlike the old version, returned data is
not converted to tuples (like in case of using "eval").
The set_modern_call_mode method was added to switch the "call"
to modern mode and back.

Closes #101
LeonidVas added a commit that referenced this issue Jul 16, 2020
@LeonidVas
add support of a new binary protocol command for "call"
f9b7480 
Added support for a new binary protocol command for "call" (used
since tarantool 1.7.2). Unlike the old version, returned data is
not converted to tuples (like in case of using "eval").
The set_modern_call_mode method was added to switch the "call"
to modern mode and back.

Closes #101
LeonidVas added a commit that referenced this issue Jul 17, 2020
@LeonidVas
add support of a new binary protocol command for "call"
e5d21cd 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
* The use_17_call method was added to switch the "call" to call_17
  mode and back.

Closes #101
@Totktonada Totktonada mentioned this issue Jul 18, 2020
Merged
LeonidVas added a commit that referenced this issue Jul 21, 2020
@LeonidVas
add support of a new binary protocol command for "call"
3c2b4bf 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_17' => true));
$c->close();
```

Closes #101
LeonidVas added a commit that referenced this issue Jul 21, 2020
@LeonidVas
add support of a new binary protocol command for "call"
27cda3c 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_17' => true));
$c->close();
```

Closes #101
LeonidVas added a commit that referenced this issue Jul 21, 2020
@LeonidVas
add support of a new binary protocol command for "call"
7114c29 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_17' => true));
$c->close();
```

Closes #101
LeonidVas added a commit that referenced this issue Jul 21, 2020
@LeonidVas
add support of a new binary protocol command for "call"
15f563f 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_17' => true));
$c->close();
```

Closes #101
LeonidVas added a commit that referenced this issue Jul 21, 2020
@LeonidVas
add support of a new binary protocol command for "call"
b4a0352 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_17' => true));
$c->close();
```

Closes #101
LeonidVas added a commit that referenced this issue Jul 24, 2020
@LeonidVas
add support of a new binary protocol command for "call"
9733a34 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_17' => true));
$c->close();
```

Closes #101
LeonidVas added a commit that referenced this issue Jul 27, 2020
@LeonidVas
add support of a new binary protocol command for "call"
389e87f 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_16' => false));
$c->close();
```

Closes #101
Totktonada pushed a commit that referenced this issue Jul 27, 2020
@LeonidVas @Totktonada
add support of a new binary protocol command for "call"
a631b56 
* Added support for a new binary protocol command for "call" (used
  since tarantool 1.7.2). Unlike the old version, returned data is
  not converted to tuples (like in case of using "eval").
  Default - call_16 mode.
* Added options to "call" method. It can be used to force
  call_16 / call_17 mode.

Example:
``` php
$c = new Tarantool('localhost', 3301);
$c->connect();
$c->call("test_call", array(), array('call_16' => false));
$c->close();
```

Closes #101
@oleg-jukovec oleg-jukovec mentioned this issue Jul 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonidVas LeonidVas

Labels
feature A new functionality php7
Projects
None yet
Milestone
PHP 7.* + bugfixes
Development

Successfully merging a pull request may close this issue.

Support call 17 tarantool/tarantool-php
5 participants
@Totktonada @bigbes @mejedi @rtsisyk @LeonidVas