Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 7.3 support #139

Closed
rybakit opened this issue Oct 25, 2018 · 4 comments
Closed

Add PHP 7.3 support #139

rybakit opened this issue Oct 25, 2018 · 4 comments
Milestone
Support PHP 7.*

Comments

@rybakit
Copy link
Collaborator

rybakit commented Oct 25, 2018

Ref: https://blog.remirepo.net/post/2018/07/02/PHP-extensions-status-with-upcoming-PHP-7.3
@Totktonada Totktonada mentioned this issue Dec 12, 2018
Closed
@Totktonada
Copy link
Member

A user observed the build fail:

/var/tmp/tarantool/src/tarantool.c: In function ‘zim_Tarantool___construct’:
/var/tmp/tarantool/src/tarantool.c:1153:20: error: lvalue required as left operand of assignment
   GC_REFCOUNT(&le) = 1;
                    ^
Makefile:193: recipe for target 'src/tarantool.lo' failed

It seems that we should use GC_SET_REFCOUNT(&le, 1); on PHP 7.3, see https://github.com/couchbase/php-couchbase/pull/22/files#diff-0681ab7d7064f2e8b779813c9c114005R288

@bigbes
Copy link
Contributor

bigbes commented Apr 3, 2019 •
edited by Totktonada
Loading

https://cismon.net/2018/02/06/Changes-of-Zend-API-in-PHP-7.3/

Update by @Totktonada: The link is died. Actual one is https://github.com/CismonX/cismon.net/blob/master/source/_posts/Changes-of-Zend-API-in-PHP-7.3.md

@SonSergei
Copy link

See #148

Totktonada pushed a commit that referenced this issue Mar 23, 2020
@Totktonada
Support PHP 7.3
300e3af 
See [1] for the list of changes of the PHP internal API. The following
items are relevant here:

c. Array/Object recursion protection
e. AST and IS_CONSTANT
f. GC_REFCOUNT()

[1]: https://github.com/php/php-src/blob/PHP-7.3.16/UPGRADING.INTERNALS

Fixes #139.

@Totktonada: style and naming fixes.
This was referenced Mar 23, 2020
Closed
Closed
Totktonada pushed a commit that referenced this issue Mar 23, 2020
@Totktonada
Support PHP 7.3
82431c4 
See [1] for the list of changes of the PHP internal API. The following
items are relevant here:

c. Array/Object recursion protection
e. AST and IS_CONSTANT
f. GC_REFCOUNT()

[1]: https://github.com/php/php-src/blob/PHP-7.3.16/UPGRADING.INTERNALS

Fixes #139.

@Totktonada: style and naming fixes.
@Totktonada Totktonada added this to the Support PHP 7.* milestone Mar 23, 2020
@Totktonada Totktonada mentioned this issue Mar 23, 2020
Closed
Totktonada pushed a commit that referenced this issue Mar 25, 2020
@Totktonada
Support PHP 7.3
9dd2f8d 
See [1] for the list of changes of the PHP internal API. The following
items are relevant here:

c. Array/Object recursion protection
e. AST and IS_CONSTANT
f. GC_REFCOUNT()

[1]: https://github.com/php/php-src/blob/PHP-7.3.16/UPGRADING.INTERNALS

Fixes #139.

@Totktonada: style and naming fixes.
@Totktonada Totktonada mentioned this issue Mar 26, 2020
Merged
Totktonada pushed a commit that referenced this issue Mar 26, 2020
@Totktonada
Support PHP 7.3
3d0962b 
See [1] for the list of changes of the PHP internal API. The following
items are relevant here:

c. Array/Object recursion protection
e. AST and IS_CONSTANT
f. GC_REFCOUNT()

[1]: https://github.com/php/php-src/blob/PHP-7.3.16/UPGRADING.INTERNALS

Fixes #139.

@Totktonada: style and naming fixes.
Totktonada pushed a commit that referenced this issue Mar 28, 2020
@Totktonada
Support PHP 7.3
d1f2a0e 
See [1] for the list of changes of the PHP internal API. The following
items are relevant here:

c. Array/Object recursion protection
e. AST and IS_CONSTANT
f. GC_REFCOUNT()

[1]: https://github.com/php/php-src/blob/PHP-7.3.16/UPGRADING.INTERNALS

Fixes #139.

@Totktonada: style and naming fixes.
@Totktonada
Copy link
Member

Totktonada commented Mar 28, 2020 •
edited
Loading

Fixed in php7-v2 branch in 0.3.0-24-gd1f2a0e. It'll be switched to master in the scope of #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Support PHP 7.*
Development

No branches or pull requests
4 participants
@Totktonada @bigbes @rybakit @SonSergei