-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated PHPUnit to version 7 + gh-24 + gh-42 + gh-85 + gh-83 + gh-71 #134
Changes from 1 commit
108b658
e93c8ed
e50e288
35daa0a
bf6ef57
13d2653
4567e20
6453c4b
dd8b8fe
5546eae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -629,6 +629,55 @@ int convert_iterator(zval *iter, int all) { | |
return -1; | ||
} | ||
|
||
int obtain_space_by_spaceno(tarantool_connection *obj, uint32_t space_no) { | ||
if (tarantool_schema_has_space_no(obj->schema, space_no)) { | ||
return 0; | ||
} | ||
|
||
tarantool_tp_update(obj->tps); | ||
tp_select(obj->tps, SPACE_SPACE, INDEX_SPACE_NO, 0, 4096); | ||
tp_key(obj->tps, 1); | ||
tp_encode_uint(obj->tps, space_no); | ||
tp_reqid(obj->tps, TARANTOOL_G(sync_counter)++); | ||
|
||
obj->value->len = tp_used(obj->tps); | ||
tarantool_tp_flush(obj->tps); | ||
|
||
if (tarantool_stream_send(obj) == FAILURE) | ||
return FAILURE; | ||
|
||
char pack_len[5] = {0, 0, 0, 0, 0}; | ||
if (tarantool_stream_read(obj, pack_len, 5) == FAILURE) | ||
return FAILURE; | ||
size_t body_size = php_mp_unpack_package_size(pack_len); | ||
smart_string_ensure(obj->value, body_size); | ||
if (tarantool_stream_read(obj, obj->value->c, | ||
body_size) == FAILURE) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Underindented. |
||
return FAILURE; | ||
|
||
struct tnt_response resp; memset(&resp, 0, sizeof(struct tnt_response)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nit: two operators on the same line. |
||
if (php_tp_response(&resp, obj->value->c, body_size) == -1) { | ||
tarantool_throw_parsingexception("query"); | ||
return FAILURE; | ||
} | ||
|
||
if (resp.error) { | ||
tarantool_throw_clienterror(resp.code, resp.error, | ||
resp.error_len); | ||
return FAILURE; | ||
} | ||
|
||
if (tarantool_schema_add_spaces(obj->schema, resp.data, resp.data_len)) { | ||
tarantool_throw_parsingexception("schema (space)"); | ||
return FAILURE; | ||
} | ||
if (!tarantool_schema_has_space_no(obj->schema, space_no)) { | ||
THROW_EXC("No space %u defined", space_no); | ||
return FAILURE; | ||
} | ||
return 0; | ||
} | ||
|
||
int get_spaceno_by_name(tarantool_connection *obj, zval *name) { | ||
if (Z_TYPE_P(name) == IS_LONG) | ||
return Z_LVAL_P(name); | ||
|
@@ -695,6 +744,11 @@ int get_indexno_by_name(tarantool_connection *obj, int space_no, | |
THROW_EXC("Index ID must be String or Long"); | ||
return FAILURE; | ||
} | ||
|
||
if (obtain_space_by_spaceno(obj, space_no) == FAILURE) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think this call should be a part of get_spaceno_by_name. |
||
return FAILURE; | ||
} | ||
|
||
int32_t index_no = tarantool_schema_get_iid_by_string(obj->schema, | ||
space_no, Z_STRVAL_P(name), Z_STRLEN_P(name)); | ||
if (index_no != FAILURE) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block (here and below) was mostly copy-pasted from
get_spaceno_by_name
. It worth to wrap it into a function I think.