Fix authentication to Tarantool >= 2.11 #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The authentication method is checked on the server-side since Tarantool 2.11 [1]. In fact, this has been required before [2]. So we need to add the authorization method value into the AUTH_REQUEST. 1. tarantool/tarantool@b5754d3 2. https://www.tarantool.io/en/doc/1.10/dev_guide/internals_index/#authentication Co-authored-by: Ivan Keberlein <i.keberleyn@it.ecommpay.com>
oleg-jukovec
force-pushed
the
oleg-jukovec/auth-fix
branch
2 times, most recently
from
25f2382 to
9e31f37
Compare
The patch replaces `assertRegExp` with `assertMatchesRegularExpression` because the first one is outdated. Closes #157
oleg-jukovec
force-pushed
the
oleg-jukovec/auth-fix
branch
from
9e31f37 to
3ebf76b
Compare
DerekBum
approved these changes
Jun 24, 2024
The patch removes `<file>test/AssertTest.php</file>` duplicate line from the `test/shared/phpunit.xml`.
oleg-jukovec
force-pushed
the
oleg-jukovec/auth-fix
branch
from
3ebf76b to
196eae7
Compare
DifferentialOrange
approved these changes
Jun 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The authentication method is checked on the server-side since Tarantool 2.11 [1]. In fact, this has been required before [2].
So we need to add the authorization method value into the
AUTH_REQUEST.