Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable reproduce trace for sql-tap/ tests #113

Closed
Korablev77 opened this issue Aug 13, 2018 · 3 comments
Closed

Disable reproduce trace for sql-tap/ tests #113

Korablev77 opened this issue Aug 13, 2018 · 3 comments
Assignees
@sergw
Labels
feature A new functionality

Comments

@Korablev77
Copy link

It seems that each of sql-tap/ tests run with brand new Tarantool instance, so it makes no sense to display reproduce sequence for them.
@Totktonada
Copy link
Member

I propose to add an option to suite.ini. Possible name: show_reproduce_content = True|False (default: True).

@Totktonada Totktonada added the feature A new functionality label Aug 13, 2018
@sergw sergw self-assigned this Aug 13, 2018
@Korablev77
Copy link
Author

I guess for sql-tap tests default option should be False: I can't come up with situation when reproducer would be really helpful for sql-tap.

@Totktonada
Copy link
Member

@Korablev77 This is test-run repository, not tarantool. Here we add the option, then one will use it for sql-tap suite in the tarantool repository.

sergw pushed a commit that referenced this issue Aug 20, 2018
Add new config param 'show_reproduce_content'
65e6f91 
By default this param is True, if the test fails then the contents of
reproduce file are displayed. If the parameter is False, do not show
the contents of reproduce file.  For example, the 'sql-tap' tests run
each case in a separate tarantool instance, so reproduce is not
necessary for problem investigation. Used in 'suite.ini'.

Closes #113
sergw pushed a commit that referenced this issue Aug 20, 2018
Add new config param 'show_reproduce_content'
0556c4f 
By default this param is True, if the test fails then the contents of
reproduce file are displayed. If the parameter is False, do not show
the contents of reproduce file.  For example, the 'sql-tap' tests run
each case in a separate tarantool instance, so reproduce is not
necessary for problem investigation. Used in 'suite.ini'.

Closes #113
@sergw sergw mentioned this issue Aug 20, 2018
Merged
sergw pushed a commit to tarantool/tarantool that referenced this issue Aug 20, 2018
test: Disable reproduce trace for sql-tap/ tests
0b874ac 
Each of sql-tap/ tests run with brand new Tarantool instance, so it
makes no sense to display reproduce sequence for them.

Part of tarantool/test-run#113
sergw pushed a commit that referenced this issue Sep 3, 2018
Add new config param 'show_reproduce_content'
f4dc586 
By default this param is True, if the test fails then the contents of
reproduce file are displayed. If the parameter is False, do not show
the contents of reproduce file.  For example, the 'sql-tap' tests run
each case in a separate tarantool instance, so reproduce is not
necessary for problem investigation. Used in 'suite.ini'.

Closes #113
sergw pushed a commit that referenced this issue Sep 4, 2018
Add new config param 'show_reproduce_content'
8275641 
By default this param is True, if the test fails then the contents of
reproduce file are displayed. If the parameter is False, do not show
the contents of reproduce file.  For example, the 'sql-tap' tests run
each case in a separate tarantool instance, so reproduce is not
necessary for problem investigation. Used in 'suite.ini'.

Closes #113
@sergw sergw closed this as completed in #116 Sep 4, 2018
sergw pushed a commit that referenced this issue Sep 4, 2018
Add new config param 'show_reproduce_content'
e092bd4 
By default this param is True, if the test fails then the contents of
reproduce file are displayed. If the parameter is False, do not show
the contents of reproduce file.  For example, the 'sql-tap' tests run
each case in a separate tarantool instance, so reproduce is not
necessary for problem investigation. Used in 'suite.ini'.

Closes #113
sergw pushed a commit to tarantool/tarantool that referenced this issue Sep 11, 2018
test: update submodule test-run
d08d91e 
* Allow to use unix socket for non-default servers
  (tarantool/test-run#115)
* Fix inspector error reporting for app tests
* Add new config param 'show_reproduce_content'
  (tarantool/test-run#113)
* Print last 15 lines of .result for hung tests
  (tarantool/test-run#107)
sergw pushed a commit to tarantool/tarantool that referenced this issue Oct 26, 2018
test: disable show_reproduce_content for sql-tap
4f29bdd 
Part of: [tarantool/test-run#113]
locker pushed a commit to tarantool/tarantool that referenced this issue Dec 19, 2018
@locker
test: disable show_reproduce_content for sql-tap
e96cd17 
Part of: [tarantool/test-run#113]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergw sergw

Labels
feature A new functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Totktonada @sergw @Korablev77