Fail testing when test-run fails internally #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit handles the case when test-run found that some of scheduled tasks were not reported as finished by workers. The old behaviour leads to zero exit code in the case when --force option is not set (looks as the unintended mistake). Now this situation causes a testing fail (non-zero exit code) and it does not matter whether --force option is set. Show list of failed tasks always except the case when it is caused by a keyboard interruption. While we are here clarified and changed related test-run messages. All that is about the situation that should never occur. See #115 for such cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit handles the case when test-run found that some of scheduled
tasks were not reported as finished by workers. The old behaviour leads
to zero exit code in the case when --force option is not set (looks as
the unintended mistake).
Now this situation causes a testing fail (non-zero exit code) and it
does not matter whether --force option is set.
Show list of failed tasks always except the case when it is caused by a
keyboard interruption.
While we are here clarified and changed related test-run messages.
All that is about the situation that should never occur. See #115 for
such cases.