Add cross and dot for Vector2d and Vector3d #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sunsided this has merge conflicts |
|
@tarcieri Rebased it. |
tarcieri
reviewed
Jul 17, 2024
src/vector/vector2d.rs
Outdated
Comment on lines
44
to
47
| /// Initializes a new instance of the `Vector2d` struct. | ||
| pub fn new(x: C, y: C) -> Self { | ||
| Self { x, y } | ||
| } |
There was a problem hiding this comment.
Its members are all public. It doesn't need a constructor.
If anything, it's clearer to have explicit x: ..., y: ...
There was a problem hiding this comment.
Got it! - removed it. I had originally added it for symmetry with other crates such as nalgebra. Personally I find it more concise to create typical vectors like this, but ultimately I don't mind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may go a bit against your philosophy judging from the comments on the
to_arrayfunction(s). Here's what I did:crossanddotfunctions toVector2dandVector3dexplicitly; they still remain part of the trait, but the trait impl forwards to the concrete implementations.Vector2dthe cross-product lies outside of the plane, it promotes toVector3dinternally. This is still useful when determining which side of a line a point lies on, for example, as the Z component indicates that direction and distance.perpendicular_dotfunction performs the same but directly calculates the Z component since the others would be zero in "2D" space.All in all, just a bit more symmetry between a types and a bit of convenience for a common 2D calculation.