Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nbval tests #254

Merged
merged 2 commits into from
Oct 14, 2021
Merged

fix nbval tests #254

merged 2 commits into from
Oct 14, 2021

Conversation

epassaro
Copy link
Member

@epassaro epassaro commented Oct 7, 2021

Description

Motivation and context

Broken tests due a known bug. nbval is starting to be a dependency problem. Maybe it's a good idea for a future gsoc project (reference data tests using pytest-arraydiff as Wolfgang wants for TARDIS).

Before APE 17 migration, all the warnings were disabled via addopts = -p no:warnings in setup.cfg. Now we just filter the deprecation warnings.

How has this been tested?

  • Testing pipeline.
  • Other.

Examples

Type of change

  • Bug fix.
  • New feature.
  • Breaking change.
  • None of the above.

Checklist

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
    • (optional) I have built the documentation on my fork following the instructions.
  • I have assigned and requested two reviewers for this pull request.

@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #254 (3327d1a) into master (9f6d308) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #254   +/-   ##
=======================================
  Coverage   74.44%   74.44%           
=======================================
  Files          23       23           
  Lines        2614     2614           
=======================================
  Hits         1946     1946           
  Misses        668      668           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9958273...3327d1a. Read the comment docs.

@andrewfullard andrewfullard merged commit 0b6de92 into tardis-sn:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants