Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change prepare_atom_data() call to work with tardis restructure #169

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

jvshields
Copy link
Contributor

Stardis uses up to date tardis. A recent tardis update changed the prepare_atom_data() function to require additional arguments. This PR makes stardis run again by adding the required arguments to the function call, and should be identical to previous behavior.

andrewfullard
andrewfullard previously approved these changes Feb 12, 2024
Copy link
Contributor

@andrewfullard andrewfullard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I jumped the gun and apparently a test or two needs updating too

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eba2b6d) 68.09% compared to head (5b1e37e) 68.09%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   68.09%   68.09%           
=======================================
  Files          31       31           
  Lines        1163     1163           
=======================================
  Hits          792      792           
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jvshields jvshields merged commit 348be6a into tardis-sn:main Feb 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants