-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Regression Data Setup #213
Basic Regression Data Setup #213
Conversation
I think that this looks quite good, generally. Would using this follow the same workflow as the tardis regression tests, outlined here? https://tardis-sn.github.io/tardis/contributing/development/running_tests.html |
Hi @jvshields, I'm afraid the docs are not up to date, but you can run tests using this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-check the black formatting, but this looks good to me as far as I can tell.
from tardis.io.util import HDFWriterMixin | ||
|
||
|
||
class RegressionData: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this not just inherit from the TARDIS class?
📝 Description
Type: 🚦
testing
| 🎢infrastructure
Basic regression data setup.
📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label