Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the description of SDECPlotter._calculate_emission_luminosities #2218

Closed
wants to merge 3 commits into from

Conversation

xansh
Copy link
Member

@xansh xansh commented Feb 25, 2023

📝 Description

Type: 📝 documentation

Renamed the return variable "elements_present" to "emission_species_present" in the description of the method SDECPlotter._calculate_emission_luminosities

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

…inosities

Renamed the return variable "elements_present" to "emission_species_present" in the description
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@atharva-2001 atharva-2001 self-requested a review February 25, 2023 15:31
atharva-2001
atharva-2001 previously approved these changes Feb 25, 2023
@atharva-2001
Copy link
Member

I think fixing docstrings belongs to a much bigger project- #1208

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #2218 (d643320) into master (239e04b) will not change coverage.
The diff coverage is n/a.

❗ Current head d643320 differs from pull request most recent head bc56658. Consider uploading reports for the commit bc56658 to get more accurate results

@@           Coverage Diff           @@
##           master    #2218   +/-   ##
=======================================
  Coverage   71.81%   71.81%           
=======================================
  Files         133      133           
  Lines       12355    12355           
=======================================
  Hits         8873     8873           
  Misses       3482     3482           
Impacted Files Coverage Δ
tardis/visualization/tools/sdec_plot.py 86.19% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xansh
Copy link
Member Author

xansh commented Feb 27, 2023

@atharva-2001 I see. Should I close this one then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants