Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model restructure for IBVS #2303

Closed
wants to merge 2 commits into from
Closed

Model restructure for IBVS #2303

wants to merge 2 commits into from

Conversation

xansh
Copy link
Member

@xansh xansh commented Jun 1, 2023

📝Description

This PR restructures the Radial1DModel to support variable inner boundary velocity. This is part of the GSoC'23 project "Inner Boundary Velocity Solver".

Type: 🎢 infrastructure

📌 Resources

GSoC Ideas Page: https://tardis-sn.github.io/gsoc_2023/ideas/
Inner Boundary Velocity Solver Project Page: https://summerofcode.withgoogle.com/programs/2023/projects/uyYkVw0V

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@xansh xansh marked this pull request as draft June 1, 2023 13:35
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@Rodot- Rodot- added model IBVS Inner Boundary Velocity Solver labels Jun 1, 2023
Updated Radial1DGeometry class to make radius dependent on velocity
Made rough skeleton of updating inner boundary velocity in Simulation
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently.

Please add your name and email to .mailmap in your current branch and push the changes to this pull request.

In case you need to map an existing alias, follow this example.

@andrewfullard
Copy link
Contributor

Replaced by other model restructure work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IBVS Inner Boundary Velocity Solver model
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants