Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes gamma-ray notebook to run more easily #2348

Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jul 7, 2023

📝 Description

Type: 📝 documentation

Minor changes to properly load the test config. Still requires the compiled file of decay data.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Still requires the compiled file of decay data.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@@ -1,6 +1,7 @@
{
Copy link
Member

@xansh xansh Jul 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line #22.        path_to_decay_data="~/compiled_ensdf.hdf"

Should we include this file in the repository? Or is there a web link for this (so we can wget in the notebook)


Reply via ReviewNB

@atharva-2001 atharva-2001 self-requested a review August 9, 2023 14:33
@wkerzendorf wkerzendorf merged commit 44b2f47 into tardis-sn:master Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants