TARDIS from_config restructure #2362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds abstract model solver class and homologous model solver Co-authored-by: Alexander Grunewald <AlexanderGrunewald@users.noreply.github.com> Co-authored-by: Andreas Flörs <afloers@users.noreply.github.com> Co-authored-by: Jack O'Brien <Rodot-@users.noreply.github.com>
Added shape property to Radial1DGeometry Use ModelState in montecarlo Use Modelstate in numba Use ModelState in plasma Create RadiationField to hold temp/dilution etc properties Use ModelState in simulation
Also small docstring fix for Composition
…files. Deprecated parts of the model_reader Moved from Radial1DModel to ModelState (outside of tests) Co-authored-by: Andrew <fullarda@msu.edu> Co-authored-by: Wolfgang Kerzendorf <wkerzendorf@users.noreply.github.com>
andrewfullard
changed the title
… abundances work out
…, at some point we need to just decide on the convention to use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Type: 🪲
bugfix| 🚀feature| ☣️breaking change| 🚦testing| 📝documentation| 🎢infrastructureWrite a complete description of your changes, including the necessary context or any piece of information required to understand your work.
Also, link issues affected by this pull request by using the keywords:
close,closes,closed,fix,fixes,fixed,resolve,resolvesorresolved.📌 Resources
Examples, notebooks, and links to useful references.
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel