-
-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate density in state object #2386
Integrate density in state object #2386
Conversation
Co-authored-by: Alexander Grunewald <AlexanderGrunewald@users.noreply.github.com> Co-authored-by: Andreas Flörs <afloers@users.noreply.github.com> Co-authored-by: Jack O'Brien <Rodot-@users.noreply.github.com> Co-authored-by: Andrew Fullard <andrewgfullard@gmail.com>
still some tests failing - maybe outdated.
Seems generally sensible. Would it be possible to fix at least the density tests? I think it should be possible to solve the abundance widget issue as well. |
Codecov Report
@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
- Coverage 68.50% 68.43% -0.08%
==========================================
Files 144 145 +1
Lines 13264 13220 -44
==========================================
- Hits 9087 9047 -40
+ Misses 4177 4173 -4
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
expected = pd.read_hdf(hdf_file_path, path) | ||
assert_almost_equal(actual, expected.values) | ||
|
||
|
||
def test_hdf_time_0(hdf_file_path, simulation_verysimple): | ||
actual = simulation_verysimple.model.homologous_density.time_0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we sure that time_0
and time_explosion
are equivalent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case they are because we shift everything to time_explosion. the model
object only has things at the same time.
*beep* *bop* Hi, human. The Click here to see your results. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If all of the refdata tests are going to pass, I'm happy.
another stab at the restructure