Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed file path #2670

Merged

Conversation

Knights-Templars
Copy link
Member

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Write a complete description of your changes, including the necessary context or any piece of information required to understand your work.

Also, link issues affected by this pull request by using the keywords: close, closes, closed, fix, fixes, fixed, resolve, resolves or resolved.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

andrewfullard
andrewfullard previously approved these changes Jun 21, 2024
atharva-2001
atharva-2001 previously approved these changes Jun 21, 2024
@atharva-2001 atharva-2001 self-requested a review June 21, 2024 14:08
@jvshields
Copy link
Contributor

Please move the notebook to its own subfold and not the base docs tree. Also if it's not too hard, specifying a file path that isn't relative and points to docs in the tardis folder might be easier for the data.

@Knights-Templars
Copy link
Member Author

Please move the notebook to its own subfold and not the base docs tree. Also if it's not too hard, specifying a file path that isn't relative and points to docs in the tardis folder might be easier for the data.

A new docs folder now exists inside the gamma ray module

@andrewfullard andrewfullard merged commit f84a4be into tardis-sn:master Jul 30, 2024
9 of 10 checks passed
@jvshields
Copy link
Contributor

@andrewfullard I discussed this with anirban awhile back, but I think this file path doesn't work with the build docs workflow. The notebook in this PR lives at tardis/energy_input/docs/working_gamma_ray_test.ipynb, and I think it needs to live in tardis/docs/... to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants