Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a logger widget for logging in run_tardis #2700

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
2 changes: 2 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ Christian Vogl <cvogl@mpa-garching.mpg.de> chvogl <cvogl@mpa-garching.mpg.de>

Debajyoti Dasgupta <debajyotidasgupta6@gmail.com>

Deeksha Mohanty <mohant11@msu.edu>

Dhruv Sondhi <dhruvsondhi05@gmail.com>
Dhruv Sondhi <dhruvsondhi05@gmail.com> Dhruv <dhruvsondhi05@gmail.com>
Dhruv Sondhi <dhruvsondhi05@gmail.com> Dhruv Sondhi <66117751+DhruvSondhi@users.noreply.github.com>
Expand Down
2 changes: 1 addition & 1 deletion docs/quickstart.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@
"sim = run_tardis(\"tardis_example.yml\", \n",
" virtual_packet_logging=True,\n",
" show_convergence_plots=True,\n",
" export_convergence_plots=True,\n",
" export_convergence_plots=False, #TODO: to avoid double plots\n",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to replace this parameter with a new parameter (maybe called export_static_output) which can show convergence plots and logger-widget (or atleast a fixed height html text area) for static HTML documentation website.

And setting this param to True should be controllable by identifying if the notebook execution is being done by nbsphinx/nbconvert - there should be some setting to detect that but needs research.

" log_level=\"INFO\") "
]
},
Expand Down
83 changes: 0 additions & 83 deletions tardis/io/logger/colored_logger.py

This file was deleted.

Loading
Loading