Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Montecarlo globals (limited scope) #2705

Merged

Conversation

andrewfullard
Copy link
Contributor

@andrewfullard andrewfullard commented Jul 15, 2024

📝 Description

Type: 🪲 bugfix

A more limited form of #2697 that only refactors into 2 constants: CONTINUUM_PROCESSES_ENABLED and ENABLE_RPACKET_TRACKING.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@andrewfullard
Copy link
Contributor Author

My attempt to fix codecov values didn't work, can you take a look @atharva-2001 @KasukabeDefenceForce ?

@atharva-2001
Copy link
Member

I'll fix codecov in #2699 or in a new separate PR.

@atharva-2001
Copy link
Member

Looks good to me. Merging it!

@atharva-2001 atharva-2001 merged commit 681bd2b into tardis-sn:master Jul 16, 2024
17 checks passed
sarthak-dv pushed a commit to sarthak-dv/tardis that referenced this pull request Jul 16, 2024
* Initial restructure of configs

* Continuum processes to global

* Fixes mistakes

* RPacket tracking global

* Split tests for rpacket tracking, move codecov detection for now
sarthak-dv pushed a commit to sarthak-dv/tardis that referenced this pull request Jul 16, 2024
* Initial restructure of configs

* Continuum processes to global

* Fixes mistakes

* RPacket tracking global

* Split tests for rpacket tracking, move codecov detection for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants