Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pipeline Fixes #2767

Merged
merged 7 commits into from
Aug 2, 2024

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Jul 30, 2024

📝 Description

Type: 🪲 bugfix | 🚀 feature | ☣️ breaking change | 🚦 testing | 📝 documentation | 🎢 infrastructure

Fixes zenodo badge
https://github.com/atharva-2001/tardis/tree/fix_zenodo_readme?tab=readme-ov-file

Pre release codecov works
https://github.com/tardis-sn/tardis/actions/runs/10214070406/job/28261177349?pr=2767

The compare refdata pipeline will have to be fixed in the tardis-refdata repo.

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@tardis-bot
Copy link
Contributor

tardis-bot commented Jul 30, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (9f2eed0).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

Complete output(might be large):

@atharva-2001 atharva-2001 marked this pull request as ready for review July 30, 2024 15:34
@andrewfullard
Copy link
Contributor

andrewfullard commented Jul 30, 2024

  1. do we know why the DOI changed? (looks like they redirect)
  2. Zenodo's release(s) are missing all of 2024

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.42%. Comparing base (c82dde5) to head (9f2eed0).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2767      +/-   ##
==========================================
- Coverage   69.98%   69.42%   -0.56%     
==========================================
  Files         196      196              
  Lines       15008    15008              
==========================================
- Hits        10503    10419      -84     
- Misses       4505     4589      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@atharva-2001 atharva-2001 marked this pull request as draft July 30, 2024 16:34
@tardis-bot
Copy link
Contributor

*beep* *bop*

Hi, human.

The docs workflow has succeeded ✔️

Click here to see your results.

@atharva-2001 atharva-2001 changed the title Fix Zenodo badge in README Release Pipeline Fixes Aug 2, 2024
@atharva-2001 atharva-2001 marked this pull request as ready for review August 2, 2024 11:08
@atharva-2001
Copy link
Member Author

  1. do we know why the DOI changed? (looks like they redirect)
image
  1. Zenodo's release(s) are missing all of 2024-
    There was a switch which was off- and the website said that the sync will turn on once I turn the switch on. This cannot be tested on this repo since until we don't have an official release, but I tested it on my fork using our release workflow and it published on zenodo.

@tardis-bot
Copy link
Contributor

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (c82dde5) and the latest commit (9f2eed0).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

All benchmarks:

| Change   | Before [c82dde5f] <master>   | After [9f2eed03]    | Ratio   | Benchmark (Parameter)                                                                                                                                                                                                                              |
|----------|------------------------------|---------------------|---------|----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
|          | 2.55±0.8μs                   | 2.81±0.9μs          | ~1.10   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000.0, 255.5)                                                                                                                                    |
|          | 2.78±0.9μs                   | 2.63±0.8μs          | 0.94    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000.0, 511.0)                                                                                                                                    |
|          | 3.33±1μs                     | 2.37±0.8μs          | ~0.71   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000.0, 5110000000.0)                                                                                                                             |
|          | 2.77±1μs                     | 2.74±0.9μs          | 0.99    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000000000.0, 255.5)                                                                                                                              |
|          | 2.98±1μs                     | 2.35±0.7μs          | ~0.79   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000000000.0, 511.0)                                                                                                                              |
|          | 4.30±2μs                     | 3.16±1μs            | ~0.73   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(100000000000.0, 5110000000.0)                                                                                                                       |
|          | 2.76±0.9μs                   | 2.83±1μs            | 1.03    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(1000000000000000.0, 255.5)                                                                                                                          |
|          | 2.60±0.9μs                   | 2.44±0.8μs          | 0.94    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(1000000000000000.0, 511.0)                                                                                                                          |
|          | 2.83±1μs                     | 2.45±0.8μs          | ~0.87   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation(1000000000000000.0, 5110000000.0)                                                                                                                   |
|          | 4.75±2μs                     | 3.93±1μs            | ~0.83   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.0})                                                                        |
|          | 5.07±2μs                     | 4.41±2μs            | ~0.87   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.5})                                                                        |
|          | 4.98±2μs                     | 4.47±2μs            | ~0.90   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 511.0, 'Iron_group_fraction': 0.5})                                                                        |
|          | 4.95±2μs                     | 4.09±2μs            | ~0.83   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 5110000000.0, 'Iron_group_fraction': 0.0})                                                                 |
|          | 25.7±10μs                    | 4.42±2μs            | ~0.17   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation({'Ejecta_density': 100000.0, 'Energy': 255.5, 'Iron_group_fraction': 1.0})                                                                    |
|          | 6.28±3μs                     | 4.71±2μs            | ~0.75   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.0})                                                                      |
|          | 5.55±2μs                     | 4.87±2μs            | ~0.88   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 255.5, 'Iron_group_fraction': 0.5})                                                                      |
|          | 5.28±2μs                     | 4.77±2μs            | ~0.90   | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 511.0, 'Iron_group_fraction': 0.5})                                                                      |
|          | 4.64±2μs                     | 4.61±2μs            | 0.99    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 0.01, 'Energy': 5110000000.0, 'Iron_group_fraction': 0.0})                                                               |
|          | 4.69±2μs                     | 4.72±2μs            | 1.01    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation({'Ejecta_density': 100000.0, 'Energy': 255.5, 'Iron_group_fraction': 1.0})                                                                  |
|          | 1.49±0.01s                   | 1.52±0.01s          | 1.02    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                                                                                                                                  |
|          | 1.49±0.01s                   | 1.51±0.01s          | 1.01    | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                                                                                                                                    |
|          | 39.8±0.01s                   | 39.8±0.01s          | 1.00    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                                                                                                                                      |
|          | 1.03±0m                      | 1.02±0m             | 0.99    | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                                                                                                                                     |
|          | 2.14±0m                      | 2.14±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                                                                                                                                |
|          | 2.94±0.9μs                   | 3.50±1μs            | ~1.19   | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body({'nu': 100000000000000.0, 'temperature': 10000.0})                                                                                                   |
|          | 65.9±20μs                    | 66.7±20μs           | 1.01    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                                                                                                                               |
|          | 76.7±10μs                    | 69.3±10μs           | ~0.90   | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line({'packet': {'nu_line': 0.1, 'is_last_line': True}, 'enable_full_relativity': True})                                               |
|          | 73.6±10μs                    | 71.2±10μs           | 0.97    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line({'packet': {'nu_line': 0.2, 'is_last_line': False}, 'enable_full_relativity': True})                                              |
|          | 83.8±20μs                    | 87.5±20μs           | 1.04    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators({'cur_line_id': 0, 'distance_trace': 0, 'time_explosion': 52000000.0, 'enable_full_relativity': True})               |
|          | 100±30μs                     | 84.3±20μs           | ~0.84   | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators({'cur_line_id': 0, 'distance_trace': 1000000000000.0, 'time_explosion': 52000000.0, 'enable_full_relativity': True}) |
|          | 83.2±20μs                    | 86.9±20μs           | 1.05    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators({'cur_line_id': 1, 'distance_trace': 100000.0, 'time_explosion': 10000000000.0, 'enable_full_relativity': False})    |
|          | 7.73±0.02s                   | 7.91±0.03s          | 1.02    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission({'mu': 0.8599443103322428, 'emission_line_id': 1000, 'energy': 0.9114437898710559})                                                                    |
|          | 7.78±0.01s                   | 7.96±0.01s          | 1.02    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter(<LineInteractionType.MACROATOM: 2>)                                                                                                                     |
|          | 7.78±0.05s                   | 7.90±0.03s          | 1.01    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter(<LineInteractionType.SCATTER: 0>)                                                                                                                       |
|          | 3.63±0.01s                   | 3.59±0.03s          | 0.99    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                                                                                                                                      |
|          | 5.03±0.06s                   | 5.15±0.02s          | 1.02    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                                                                                                                                            |
|          | 22.7±7μs                     | 32.9±10μs           | ~1.45   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(10)                                                                                                            |
|          | 61.7±20μs                    | 34.5±9μs            | ~0.56   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(100)                                                                                                           |
|          | 136±20μs                     | 140±20μs            | 1.03    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list(1000)                                                                                                          |
|          | 28.6±10μs                    | 29.9±10μs           | 1.04    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(1, 1)                                                                                                                           |
|          | 27.4±10μs                    | 32.0±10μs           | ~1.16   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(1, 10)                                                                                                                          |
|          | 30.4±10μs                    | 34.5±10μs           | ~1.13   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(1, 50)                                                                                                                          |
|          | 37.7±10μs                    | 48.7±20μs           | ~1.29   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 1)                                                                                                                          |
|          | 38.9±10μs                    | 43.9±10μs           | ~1.13   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 10)                                                                                                                         |
|          | 35.3±9μs                     | 45.4±10μs           | ~1.28   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(10, 50)                                                                                                                         |
|          | 68.4±10μs                    | 130±30μs            | ~1.90   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(50, 1)                                                                                                                          |
|          | 70.7±10μs                    | 108±30μs            | ~1.53   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(50, 10)                                                                                                                         |
|          | 79.9±10μs                    | 92.9±20μs           | ~1.16   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list(50, 50)                                                                                                                         |
|          | 1.48±0s                      | 1.48±0.02s          | 1.00    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                                                                                                                                 |
|          | 6.53±0.04s                   | 6.42±0.01s          | 0.98    | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                                                                                                                                       |
|          | 4.98±0.02s                   | 5.01±0.02s          | 1.01    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                                                                                                                                      |
|          | 5.04±0.01s                   | 5.06±0.01s          | 1.00    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                                                                                                                                          |
|          | 4.95±0.02s                   | 4.93±0.01s          | 1.00    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley({'tau_russian': 10.0, 'survival_possibility': 0.0})                                                                                               |
|          | 5.03±0.03s                   | 4.99±0.01s          | 0.99    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley({'tau_russian': 15.0, 'survival_possibility': 0.1})                                                                                               |
|          | 3.58±0s                      | 3.61±0s             | 1.01    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                                                                                                                                             |

If you want to see the graph of the results, you can check it here

@Knights-Templars Knights-Templars merged commit 1807f36 into tardis-sn:master Aug 2, 2024
19 of 21 checks passed
officialasishkumar added a commit to officialasishkumar/tardis that referenced this pull request Aug 2, 2024
* added setup function

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* refactor geometry calculate distances

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* Refactor montecarlo estimators in benchmark code

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* add cache and setup functions

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* add cache and setup functions

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* ran ruff linter

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* Thou hath vanquished the redundant variables and functions

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* fix bugs

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* change benchmark yml

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* repeat in class

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* Benchmark run_tardis with track_rpacket enabled (tardis-sn#2720)

* Benchmark run_tardis with track_rpacket enabled

* Update config to resemble time_run_tardis config

* Fix Benchmark error

* Cache Benchmark Property

* Remove Cached Property decorator

* rounds in benchmarks

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* fix

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* fix error in formal integral

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* more cache

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* sort by ratio

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* Donot run docs, benchmarks and stardis tests on draft PRs. (tardis-sn#2761)

* Add ready to review to run tests

* Add if condition to check PR status

* Running stardis tests only on push to master

* Removing osx-64 from workflows

* Add Extend Array Function (tardis-sn#2771)

* Add Extend Array Function

* Fix Typo and restructure

* Restructure

* Doc string update

* Was expecting numpy arrays to be passed by reference but it is not so updating it

* Add test for the extend array function

* Opacity state slice (tardis-sn#2758)

* Added basic sliing operation to opacitystate and set the transport solver to use the bounds of the gemoetry indices

* Reformatted the slicing index

* Added slicing operation with __getitem__

* Added docstring

* removed old slice method

* Ran black

* Added back the 'slice' method because __getitem__ is wacky

* added missing argument

* fixed missing argument

* ran black

* fixed the tests

* ran black

* Updated the slice to use __getitem__ again and modified the opacitystate object defined in the opacities module

* Removed old slice method and print statements

* removed print statement from the test

* added type annotation to OpacityState getitem

* updated numba interface

* Fixes black formatting

* Release Pipeline Fixes (tardis-sn#2767)

* Fix zenodo badge

* Pick from the website

* update badge in credits.rst

* Use the all versions DOI

* Inherit secrets

* Change triggers for testing

* Reset Triggers

* Fix ruff comments issue (tardis-sn#2762)

* Fix ruff comments issue

* Only check files changed

* Testing triggers

* Fix bash commands

* No pager

* fetch depth

* Reset all changes

* cache in setup function

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

* change benchmark yml

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>

---------

Signed-off-by: Asish Kumar <officialasishkumar@gmail.com>
Co-authored-by: Sumit Gupta <53135486+Sumit112192@users.noreply.github.com>
Co-authored-by: KasukabeDefenceForce <abhinavohri13@gmail.com>
Co-authored-by: Jack O'Brien <jobrien585@gmail.com>
Co-authored-by: Andrew Fullard <andrewgfullard@gmail.com>
Co-authored-by: Atharva Arya <55894364+atharva-2001@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants