Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert SDEC tests to Regression Data #2785

Merged
merged 11 commits into from
Aug 16, 2024

Conversation

atharva-2001
Copy link
Member

@atharva-2001 atharva-2001 commented Aug 7, 2024

📝 Description

Type: 🚦 testing
Adds SDEC regression data- tardis-sn/tardis-regression-data#15
Image tests- tardis-sn/tardis-regression-data#17

📌 Resources

Examples, notebooks, and links to useful references.

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@atharva-2001 atharva-2001 marked this pull request as ready for review August 13, 2024 12:33
@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 13, 2024

*beep* *bop*
Hi human,
I ran ruff on the latest commit (35880ec).
Here are the outputs produced.
Results can also be downloaded as artifacts here.
Summarised output:

2	I001  	[*] Import block is un-sorted or un-formatted
2	D202  	[*] No blank lines allowed after function docstring (found 1)
1	ISC003	[ ] Explicitly concatenated string should be implicitly concatenated
1	G010  	[*] Logging statement uses `warn` instead of `warning`
1	RET506	[ ] Unnecessary `elif` after `raise` statement
1	W293  	[*] Blank line contains whitespace
1	F811  	[ ] Redefinition of unused `test_generate_plot_mpl` from line 284

Complete output(might be large):

tardis/visualization/tools/liv_plot.py:1:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/liv_plot.py:25:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/visualization/tools/liv_plot.py:48:9: D202 [*] No blank lines allowed after function docstring (found 1)
tardis/visualization/tools/liv_plot.py:312:13: RET506 Unnecessary `elif` after `raise` statement
tardis/visualization/tools/liv_plot.py:313:24: G010 [*] Logging statement uses `warn` instead of `warning`
tardis/visualization/tools/tests/test_sdec_plot.py:2:1: I001 [*] Import block is un-sorted or un-formatted
tardis/visualization/tools/tests/test_sdec_plot.py:207:1: W293 [*] Blank line contains whitespace
tardis/visualization/tools/tests/test_sdec_plot.py:318:29: ISC003 Explicitly concatenated string should be implicitly concatenated
tardis/visualization/tools/tests/test_sdec_plot.py:373:9: F811 Redefinition of unused `test_generate_plot_mpl` from line 284
Found 9 errors.
[*] 6 fixable with the `--fix` option.

@tardis-bot
Copy link
Contributor

tardis-bot commented Aug 13, 2024

*beep* *bop*
Hi human,
I ran benchmarks as you asked comparing master (92df2cf) and the latest commit (35880ec).
Here are the logs produced by ASV.
Results can also be downloaded as artifacts here.

Significantly changed benchmarks:

All benchmarks:

Benchmarks that have stayed the same:

| Change   | Before [714cffc8] <master>   | After [35880ec3]    | Ratio   | Benchmark (Parameter)                                                                                                               |
|----------|------------------------------|---------------------|---------|-------------------------------------------------------------------------------------------------------------------------------------|
|          | 4.39±0.4μs                   | 5.49±0.6μs          | ~1.25   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_bad_vpacket                                       |
|          | 3.86±0.06ms                  | 4.80±0.03ms         | ~1.24   | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('macroatom')                                   |
|          | 6.75±0.5μs                   | 7.59±0.3μs          | ~1.12   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket                                           |
|          | 2.97±0.01ms                  | 2.68±0.01ms         | ~0.90   | opacities_opacity_state.BenchmarkOpacitiesOpacityState.time_opacity_state_initialize('scatter')                                     |
|          | 8.52±2μs                     | 7.69±3μs            | ~0.90   | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_volley                                    |
|          | 3.60±0.6ms                   | 3.17±0.7ms          | ~0.88   | transport_montecarlo_single_packet_loop.BenchmarkTransportMontecarloSinglePacketLoop.time_single_packet_loop                        |
|          | 1.32±0m                      | 1.11±0.01m          | ~0.84   | run_tardis.BenchmarkRunTardis.time_run_tardis_rpacket_tracking                                                                      |
|          | 25.4±6μs                     | 21.2±5μs            | ~0.84   | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_last_interaction_tracker_list |
|          | 541±100ns                    | 590±100ns           | 1.09    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_compton_opacity_calculation                                      |
|          | 48.9±30μs                    | 52.7±30μs           | 1.08    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_scatter                                          |
|          | 1.70±0.02ms                  | 1.82±0.02ms         | 1.08    | transport_montecarlo_main_loop.BenchmarkTransportMontecarloMontecarloMainLoop.time_montecarlo_main_loop                             |
|          | 2.08±2μs                     | 2.20±2μs            | 1.06    | transport_montecarlo_estimators_radfield_estimator_calcs.BenchmarkMontecarloMontecarloNumbaPacket.time_update_line_estimators       |
|          | 531±200ns                    | 551±200ns           | 1.04    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_pair_creation_opacity_calculation                                |
|          | 1.18±0.01μs                  | 1.23±0μs            | 1.04    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_boundary                |
|          | 63.5±0.3ms                   | 66.3±0.1ms          | 1.04    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_rpacket_trackers_to_dataframe                  |
|          | 601±200ns                    | 622±100ns           | 1.03    | opacities_opacity.BenchmarkMontecarloMontecarloNumbaOpacities.time_photoabsorption_opacity_calculation                              |
|          | 39.9±0.2s                    | 41.2±0.2s           | 1.03    | run_tardis.BenchmarkRunTardis.time_run_tardis                                                                                       |
|          | 1.66±0.4μs                   | 1.68±0.3μs          | 1.01    | transport_geometry_calculate_distances.BenchmarkTransportGeometryCalculateDistances.time_calculate_distance_line                    |
|          | 2.12±0m                      | 2.12±0m             | 1.00    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_FormalIntegrator_functions                                 |
|          | 741±4ns                      | 741±0.3ns           | 1.00    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_thomson_scatter                                       |
|          | 212±0.9ns                    | 209±0.4ns           | 0.99    | spectrum_formal_integral.BenchmarkTransportMontecarloFormalIntegral.time_intensity_black_body                                       |
|          | 3.58±0.5μs                   | 3.47±0.5μs          | 0.97    | transport_montecarlo_vpacket.BenchmarkMontecarloMontecarloNumbaVpacket.time_trace_vpacket_within_shell                              |
|          | 32.4±0.1μs                   | 31.3±0.04μs         | 0.96    | transport_montecarlo_packet_trackers.BenchmarkTransportMontecarloPacketTrackers.time_generate_rpacket_tracker_list                  |
|          | 48.7±40μs                    | 45.5±20μs           | 0.93    | transport_montecarlo_interaction.BenchmarkTransportMontecarloInteraction.time_line_emission                                         |

If you want to see the graph of the results, you can check it here

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 76.11940% with 32 lines in your changes missing coverage. Please review.

Project coverage is 69.37%. Comparing base (92df2cf) to head (35880ec).
Report is 4 commits behind head on master.

Files Patch % Lines
tardis/visualization/tools/tests/test_sdec_plot.py 76.11% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2785      +/-   ##
==========================================
- Coverage   69.97%   69.37%   -0.61%     
==========================================
  Files         206      206              
  Lines       15509    15518       +9     
==========================================
- Hits        10853    10765      -88     
- Misses       4656     4753      +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

andrewfullard
andrewfullard previously approved these changes Aug 14, 2024
@andrewfullard andrewfullard merged commit ef8a5ac into tardis-sn:master Aug 16, 2024
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants