Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move off of olafurpg/setup-scala in Actions #142

Closed
colindean opened this issue Dec 14, 2022 · 2 comments · Fixed by #152
Closed

Move off of olafurpg/setup-scala in Actions #142

colindean opened this issue Dec 14, 2022 · 2 comments · Fixed by #152
Labels
enhancement New feature or request

Comments

@colindean
Copy link
Collaborator

Per olafurpg/setup-scala#49, olafurpg/setup-scala is ~unmaintained and there are better options available. We do have a need to compile against JDK8 so we can probably take the recommended route of using the actions/setup-java action.
@colindean colindean added the enhancement New feature or request label Dec 14, 2022
@colindean
Copy link
Collaborator Author

Another options is to use https://github.com/coursier/setup-action

@colindean
Copy link
Collaborator Author

olafurpg/setup-scala is no longer maintained, according to its v14 release notes linked in #149, so we need to move as soon as possible.

This ought to do it and enable removing the extended cache config, too:

    - uses: coursier/cache-action@v6
    - uses: coursier/setup-action@v1
      with:
        jvm: adopt:1.8

colindean added a commit that referenced this issue Apr 3, 2023
@colindean
Use coursier/setup-action instead of deprecated olafurpg/setup-scala
043cc21 
There were many options suggested in text and in other PRs linked from
olafurpg/setup-scala#49 but this seems to make
the most sense for DV and also _really_ reduces the workflow code.

Fixes #142
@colindean colindean mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use coursier/setup-action instead of deprecated olafurpg/setup-scala target/data-validator
1 participant
@colindean