Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(log): convert from logrus to zerolog #173

Merged
merged 3 commits into from
Apr 28, 2021

Conversation

alankan886
Copy link
Contributor

Proposed change

Converting logrus to zerolog in the project, #66.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@coveralls
Copy link

coveralls commented Apr 27, 2021

Pull Request Test Coverage Report for Build 791187668

  • 53 of 193 (27.46%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 35.015%

Changes Missing Coverage Covered Lines Changed/Added Lines %
remote/cli/remote.go 0 1 0.0%
handlers/script.go 5 7 71.43%
core/configure.go 23 26 88.46%
core/matcher.go 15 18 83.33%
core/prommetric.go 0 3 0.0%
remote/telegram/remote.go 0 3 0.0%
utils/access_check.go 9 12 75.0%
core/outputs.go 0 4 0.0%
core/remotes.go 0 4 0.0%
remote/discord/helper.go 0 5 0.0%
Totals Coverage Status
Change from base Build 731575749: -0.09%
Covered Lines: 819
Relevant Lines: 2339

💛 - Coveralls

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - thanks a ton for making those changes. Might consider using zerolog.ConsoleWriter for CLI mode at some point, but thanks for the note in the story.

One minor request - can you run make clean or at least go mod tidy and commit the changes (should just be go.sum) and we're ready to merge, i think.

@wass3r wass3r changed the title Convert from logrus to zerolog refactor(log): convert from logrus to zerolog Apr 27, 2021
@alankan886
Copy link
Contributor Author

Hey @wass3r, just ran both make clean and go mod tidy, no changes in files.

@wass3r
Copy link
Collaborator

wass3r commented Apr 28, 2021

Hmm, probably user error on my part. Otherwise maybe Go version difference? I'll double check when I get on a machine. Either way, not a huge deal. Thank you!

@alankan886
Copy link
Contributor Author

You are correct about the Go version. I upgraded from 1.15.7 to 1.16.3, ran go mod tidy again and some dependencies were removed in go.sum.

Thank you for going over the PR, please let me know if you need anything else from me!

@wass3r
Copy link
Collaborator

wass3r commented Apr 28, 2021

Awesome - thank you for the PR and follow-up! Appreciate it!

@wass3r wass3r merged commit 62cd397 into target:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants