-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(log): convert from logrus to zerolog #173
refactor(log): convert from logrus to zerolog #173
Conversation
Pull Request Test Coverage Report for Build 791187668
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great - thanks a ton for making those changes. Might consider using zerolog.ConsoleWriter
for CLI mode at some point, but thanks for the note in the story.
One minor request - can you run make clean
or at least go mod tidy
and commit the changes (should just be go.sum) and we're ready to merge, i think.
Hey @wass3r, just ran both |
Hmm, probably user error on my part. Otherwise maybe Go version difference? I'll double check when I get on a machine. Either way, not a huge deal. Thank you! |
You are correct about the Go version. I upgraded from 1.15.7 to 1.16.3, ran Thank you for going over the PR, please let me know if you need anything else from me! |
Awesome - thank you for the PR and follow-up! Appreciate it! |
Proposed change
Converting logrus to zerolog in the project, #66.
Types of changes
Checklist