Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

admin: allow Twilio messaging service SID as "from number" #1899

Merged
merged 37 commits into from
Sep 23, 2021
Merged

admin: allow Twilio messaging service SID as "from number" #1899

merged 37 commits into from
Sep 23, 2021

Conversation

dctalbot
Copy link
Contributor

@dctalbot dctalbot commented Sep 14, 2021 •
edited
Loading

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR adds support for using Twilio's messaging service SID to send messages.

@dctalbot dctalbot marked this pull request as ready for review September 15, 2021 16:46
@m17ch m17ch changed the title admin: allow messenger SID as "from number" admin: allow Twilio messaging service SID as "from number" Sep 15, 2021
m17ch
m17ch reviewed Sep 15, 2021
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
m17ch
m17ch approved these changes Sep 23, 2021
View reviewed changes
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@mastercactapus mastercactapus merged commit eaa88fb into master Sep 23, 2021
@mastercactapus mastercactapus deleted the admin-toolbox-messaging-service-support branch September 23, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m17ch m17ch m17ch approved these changes

@mastercactapus mastercactapus mastercactapus approved these changes

Assignees
No one assigned
Labels
Twilio SID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dctalbot @mastercactapus @m17ch @KatieMSB