Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

twilio: voice menu updates #1918

Merged
merged 19 commits into from
Sep 29, 2021
Merged

twilio: voice menu updates #1918

merged 19 commits into from
Sep 29, 2021

Conversation

mastercactapus
Copy link
Member

Description:

  • Fixes awkward repetition around the application name
  • Fixes handling of incoming calls and allows unsubscribing from incoming calls
  • Use summary for alert status updates instead of number (matching notification)
  • slower speaking
  • fix "star" to repeat when using non-default voices
  • more natural & consistent application introduction

@mastercactapus mastercactapus marked this pull request as ready for review September 24, 2021 20:02
@dctalbot dctalbot self-requested a review September 28, 2021 15:23
dctalbot
dctalbot suggested changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@dctalbot dctalbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When verifying contact method, it says "again, your six digit verification code is 1, 2, 3, 4, 5 ,6 period.

@mastercactapus @dctalbot
Update notification/twilio/voice.go
13e53ec 
Co-authored-by: David Talbot <david.talbot@target.com>
@dctalbot
Copy link
Contributor

Similar issue, when using an alert summary of "test 5234", this will be read as "fifty-two-hundred-thirty-four period"

dctalbot
dctalbot reviewed Sep 28, 2021
View reviewed changes
notification/twilio/voice.go Outdated Show resolved Hide resolved
notification/twilio/voice.go Show resolved Hide resolved
dctalbot
dctalbot previously approved these changes Sep 28, 2021
View reviewed changes
dctalbot
dctalbot previously approved these changes Sep 28, 2021
View reviewed changes
dctalbot
dctalbot previously approved these changes Sep 28, 2021
View reviewed changes
m17ch
m17ch approved these changes Sep 29, 2021
View reviewed changes
Copy link
Contributor

@m17ch m17ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mastercactapus mastercactapus merged commit 2d4a591 into master Sep 29, 2021
@mastercactapus mastercactapus deleted the voice-updates branch September 29, 2021 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m17ch m17ch m17ch approved these changes

@dctalbot dctalbot dctalbot approved these changes

Assignees
No one assigned
Labels
Twilio SID
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mastercactapus @dctalbot @m17ch