Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/admin: convert file to typescript #2346

Merged
merged 2 commits into from
May 2, 2022

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

web/src/app/admin/AdminDialog.tsx Outdated Show resolved Hide resolved
web/src/app/admin/AdminDialog.tsx Outdated Show resolved Hide resolved
web/src/app/admin/AdminDialog.tsx Outdated Show resolved Hide resolved
web/src/app/admin/AdminDialog.tsx Outdated Show resolved Hide resolved
@tony-tvu tony-tvu requested a review from Forfold May 2, 2022 17:42
@mastercactapus mastercactapus merged commit 1bbf5f1 into master May 2, 2022
@mastercactapus mastercactapus deleted the typescript-conversion-AdminDialog branch May 2, 2022 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants