Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/alerts: convert AlertDetails file to typescript #2364

Merged
merged 8 commits into from
May 12, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented May 4, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert javascript files to typescript.

Which issue(s) this PR fixes:
#2318

@tony-tvu tony-tvu requested a review from Forfold May 12, 2022 15:38
Forfold
Forfold previously approved these changes May 12, 2022
@tony-tvu tony-tvu requested a review from Forfold May 12, 2022 19:38
@tony-tvu tony-tvu changed the title ui/alerts: convert files to typescript ui/alerts: convert AlertDetails file to typescript May 12, 2022
@tony-tvu tony-tvu merged commit 7b2bf4f into master May 12, 2022
@tony-tvu tony-tvu deleted the typescript-conversion-AlertDetails branch May 12, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants