ui/schedules: convert ScheduleOverrideDeleteDialog to ts and use urql #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
previously approved these changes
Jun 22, 2022
…heduleOverrideDeleteDialog
KatieMSB
previously approved these changes
Jun 27, 2022
…heduleOverrideDeleteDialog
tony-tvu
changed the title
KatieMSB
approved these changes
Jul 19, 2022
Forfold
reviewed
Jul 19, 2022
Comment on lines
+57
to
+62
| const addUser = data.userOverride.addUser ? data.userOverride.addUser : '' | ||
| const removeUser = data.userOverride.removeUser | ||
| ? data.userOverride.removeUser | ||
| : '' | ||
| const start = data.userOverride.start ? data.userOverride.start : '' | ||
| const end = data.userOverride.end ? data.userOverride.end : '' |
There was a problem hiding this comment.
just a suggestion
Suggested change
| const addUser = data.userOverride.addUser ? data.userOverride.addUser : '' | |
| const removeUser = data.userOverride.removeUser | |
| ? data.userOverride.removeUser | |
| : '' | |
| const start = data.userOverride.start ? data.userOverride.start : '' | |
| const end = data.userOverride.end ? data.userOverride.end : '' | |
| const addUser = data.userOverride?.addUser ?? '' | |
| const removeUser = data.userOverride?.removeUser ?? '' | |
| const start = data.userOverride?.start ?? '' | |
| const end = data.userOverride?.end ?? '' |
Forfold
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make checkto catch common errors. Fixed any that came up.Description:
Part of an ongoing effort to convert existing javascript files to typescript.
Which issue(s) this PR fixes:
#2318
Out of Scope: