Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/lists: use component type for create dialogs #2467

Merged
merged 6 commits into from
Oct 13, 2022

Conversation

tony-tvu
Copy link
Collaborator

@tony-tvu tony-tvu commented Jun 23, 2022

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
This PR makes SimpleListPage take in a component as a prop, instead of a ReactElement, in order to make the onClose prop required for our Dialog components. Because PolicyCreateDialog and ServiceCreateDialog were still in javascript, I was running into type mismatch errors since their top-level return types were undefined, so I converted the files to typescript and gave them return types to resolve this.

Which issue(s) this PR fixes:
#2458

Out of Scope:

  • PolicyCreateDialog.js and ServiceCreateDialog.js were converted to typescript. (Related issue: ui: convert javascript files to typescript #2318)
  • The onClose prop is made required for ScheduleCreateDialog, ScheduleDeleteDialog, and ScheduleOverrideCreateDialog.

Forfold
Forfold previously approved these changes Jul 6, 2022
@stale
Copy link

stale bot commented Sep 20, 2022

This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale This is inactive label Sep 20, 2022
@stale stale bot removed the stale This is inactive label Sep 27, 2022
Forfold
Forfold previously approved these changes Oct 7, 2022
Co-authored-by: Nathaniel Cook <NathanielJCook@outlook.com>
@tony-tvu tony-tvu requested a review from Forfold October 10, 2022 21:01
@KatieMSB KatieMSB merged commit 9690e83 into master Oct 13, 2022
@KatieMSB KatieMSB deleted the component-type-dialogs branch October 13, 2022 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants