-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ui/lists: use component type for create dialogs #2467
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forfold
previously approved these changes
Jul 6, 2022
7 tasks
…nent-type-dialogs
This pull request has been automatically marked as stale because it has not had recent activity. Thank you for your contributions. |
…nent-type-dialogs
Forfold
previously approved these changes
Oct 7, 2022
Forfold
reviewed
Oct 7, 2022
Forfold
approved these changes
Oct 13, 2022
KatieMSB
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make check
to catch common errors. Fixed any that came up.Description:
This PR makes SimpleListPage take in a component as a prop, instead of a ReactElement, in order to make the onClose prop required for our Dialog components. Because PolicyCreateDialog and ServiceCreateDialog were still in javascript, I was running into type mismatch errors since their top-level return types were undefined, so I converted the files to typescript and gave them return types to resolve this.
Which issue(s) this PR fixes:
#2458
Out of Scope: