Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui/rotations: convert RotationForm to ts #2474

Merged
merged 6 commits into from
Jul 19, 2022
Merged

ui/rotations: convert RotationForm to ts #2474

merged 6 commits into from
Jul 19, 2022

Conversation

tony-tvu
Copy link
Collaborator

  • Identified the issue which this PR solves.
  • Read the CONTRIBUTING document.
  • Code builds clean without any errors or warnings.
  • Added appropriate tests for any new functionality.
  • All new and existing tests passed.
  • Added comments in the code, where necessary.
  • Ran make check to catch common errors. Fixed any that came up.

Description:
Part of an ongoing effort to convert existing javascript files to typescript.

Which issue(s) this PR fixes:
#2318

KatieMSB
KatieMSB previously approved these changes Jul 19, 2022
mastercactapus
mastercactapus previously approved these changes Jul 19, 2022
KatieMSB
KatieMSB previously approved these changes Jul 19, 2022
KatieMSB
KatieMSB previously approved these changes Jul 19, 2022
Forfold
Forfold previously approved these changes Jul 19, 2022
@KatieMSB KatieMSB dismissed stale reviews from Forfold and themself via 622768e July 19, 2022 20:54
@Forfold Forfold merged commit 716b757 into master Jul 19, 2022
@Forfold Forfold deleted the ts-RotationForm branch July 19, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants